validate: check record value formats, run the same check before every deploy - #22
Merged
Merged
Conversation
… deploy A malformed record (the aurora TXT object) was merged although the PR check was red, and it broke the deploy of the whole skillissue.gg zone. - validate-pr.js: check each value per type (IPv4, IPv6, hostname, MX, SRV, CAA, TXT without quotes, single CNAME) and export validateContent - deploy.js: run validateContent on every file before POSTing, so a broken file fails the run instead of reaching skrime, even if a red PR is merged - README: document the new rules Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vzw95xoy6RWUeGkRfgbMST
Changes requestedThanks for your submission! A few things need fixing before this can be merged:
Push a new commit to this pull request and I'll re-check automatically. |
Owner
Author
|
Generated by Claude Code |
TinyBrickBoy
marked this pull request as ready for review
September 25, 2026 09:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR hardens record validation so a broken file like the aurora TXT object (fixed in #21) can't break a deploy again. That PR was merged even though
validatewas red, and one bad record made skrime reject the whole skillissue.gg zone.validate-pr.jsA: IPv4AAAA: IPv6CNAME/ALIAS: exactly one hostnameMX:<prio> <host>SRV:<prio> <weight> <port> <target>CAA:<flags> issue|issuewild|iodef <value>TXT: no surrounding quotes, max 2048 chars_label.jsonfile instead.validateContentso the deploy script can reuse it.deploy.jsvalidateContenton every file before the POST, so a broken zone never reaches skrime, even if a red PR gets merged. The other domains still deploy.README
Tested locally:
Note:
validatefails on this PR by design because it only touches files outsidedomains/.🤖 Generated with Claude Code
https://claude.ai/code/session_01Vzw95xoy6RWUeGkRfgbMST
Generated by Claude Code