Conversation
- Implement ProtobufStructHandler for parsing .protobuf files - Add protobuf dependency (com.google.protobuf:protobuf-java:4.29.2) - Register handler in SPI configuration - Add FILE_PROTOBUF extension constant to FileExtensionMatcher - Update module-info.java with protobuf module requirement - Generate PersonProto test class for descriptor testing - Add comprehensive test suite with 33 test cases - Achieve 100% instruction and branch coverage Features: - Support for startOrder and endOrder configuration - Dynamic message parsing using protobuf descriptors - Handle empty messages and parse errors gracefully - Convert protobuf messages to StructImpl with proper field mapping - Support for repeated fields (comma-separated values)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14 +/- ##
============================================
+ Coverage 84.83% 85.35% +0.52%
- Complexity 782 809 +27
============================================
Files 65 66 +1
Lines 2327 2417 +90
Branches 394 412 +18
============================================
+ Hits 1974 2063 +89
- Misses 181 185 +4
+ Partials 172 169 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features: