Fix: Geode v5 / GD 2.2081 compatibility migration#380
Open
Kosten47 wants to merge 9 commits intoTobyAdd:mainfrom
Open
Fix: Geode v5 / GD 2.2081 compatibility migration#380Kosten47 wants to merge 9 commits intoTobyAdd:mainfrom
Kosten47 wants to merge 9 commits intoTobyAdd:mainfrom
Conversation
Owner
|
Hello, the "main" branch is currently obsolete. It will remain for Geometry Dash 2.2074 and will no longer be maintained. Currently, GDH is being rewritten, and the source code is published on the "new-5.1" branch, which includes extensive refactoring and code optimizations. Also, you are using an incorrect method to update imgui-cocos. You need to change the commit hash in the |
Author
|
Fixed, updated the commit hash in CMakeLists.txt. Sorry, first time contributing on github |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Migrates GDH from Geode SDK v4 to v5.0.0-beta.4 and adds compatibility
for Geometry Dash 2.2081.
Changes
Geode v5 API breaking changes
Popup<std::monostate>template removed in v5.All popup classes migrated to new
Popup::init(width, height, bg)pattern(affects
HacksLayer,RecorderLayer,LabelsCreateLayer,popupSystem)fmt::localtimeremoved in fmt v12, replaced withgeode::localtimeisOrWillBeEnabled()renamed toisLoaded()GD 2.2081 binding changes
GJBaseGameLayer::processCommands: signature changed from(float dt)to
(float dt, bool isHalfTick, bool isLastTick)AudioEffectsLayer::m_notAudioScale: field removed, pulse control nowonly via
FMODAudioEngine::m_pulse1GJGameLevel::m_k111: field removed in 2.2081 bindingsCCEGLView::onGLFWKeyCallback: inlined in 2.2081, cannot be hooked.Replaced with
CCKeyboardDispatcher::dispatchKeyboardMSGhook whichproperly converts VK codes to GLFW via
KeyMappingUtils::GetGLFWFromWinAPIDependencies
hooks.cpppatched via CMake for 2.2081 compatibility(
dispatchKeyboardMSGnow takes an additionaldouble timeparameter).Patch applied automatically at build time from
patches/imgui-cocos-hooks.cpp2.208to2.2081Known limitations
manual folder selection