Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds optional grid-rotation support when gridding CRUST1.0 onto the model domain, and improves robustness when reading checkerboard inputs that may lack zeta.
Changes:
- Add an optional
rotateargument toATTModel.grid_data_crust1()and plumb it through toCrustModel.griddata(). - Apply reverse rotation to the lat/lon grid before CRUST1.0 interpolation when
rotateis provided. - Make
Checkertolerate missingzetain some input HDF5 models by defaulting it to zeros.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| pytomoatt/model.py | Exposes rotate in the high-level CRUST1.0 gridding API and forwards it to the IO layer. |
| pytomoatt/io/crustmodel.py | Implements optional reverse-rotation of the interpolation grid prior to CRUST1.0 lookup. |
| pytomoatt/checkerboard.py | Makes checkerboard initialization resilient to models without a zeta dataset. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| return dataset | ||
|
|
||
| def grid_data_crust1(self, type='vp'): | ||
| def grid_data_crust1(self, type='vp', rotate=None): |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Member
|
@JingChen-Thu I have made some changes on pythonic style. Pls try again on your cases. If no issue feedback, I will merge this PR. |
xumi1993
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.