Skip to content

Conversation

@lauramurgatroyd
Copy link
Member

Describe your changes

Updates UI env.yml to also install cilviewer. This is needed because some of the dependencies require specific python versions so installing cilviewer and then the additional dependencies on top may cause it to fail

Describe any testing you have performed

Consider adding example code to examples
Tested creating an environment using the environment file on windows with conda.

Link relevant issues

Checklist when you are ready to request a review

  • I have performed a self-review of my code
  • I have added docstrings in line with the guidance in the CIL developer guide
  • I have implemented unit tests that cover any new or modified functionality
  • CHANGELOG.md has been updated with any functionality change
  • Request review from all relevant developers
  • Change pull request label to 'waiting for review'

Contribution Notes

  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in CILViewer (the Work) under the terms and conditions of the Apache-2.0 License
  • I confirm that the contribution does not violate any intellectual property rights of third parties

Qt contributions should follow Qt naming conventions i.e. camelCase method names.

VTK contributions should follow VTK naming conventions i.e. PascalCase method names.

@lauramurgatroyd lauramurgatroyd marked this pull request as ready for review November 28, 2025 13:32
Copy link
Collaborator

@paskino paskino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe in the future we could host the yaml file as we do for CIL, https://github.com/TomographicImaging/CIL#create-a-conda-environment-with-cil

@lauramurgatroyd lauramurgatroyd merged commit e30cc76 into master Nov 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants