Comparing dispatch_get_current_queue() with dispatch_get_main_queue()…#8
Open
Coeur wants to merge 1 commit intoTonnyXu:masterfrom
Coeur:patch-1
Open
Comparing dispatch_get_current_queue() with dispatch_get_main_queue()…#8Coeur wants to merge 1 commit intoTonnyXu:masterfrom Coeur:patch-1
Coeur wants to merge 1 commit intoTonnyXu:masterfrom
Coeur:patch-1
Conversation
… is not only deprecated since iOS6, but unreliable according to queue.h When dispatch_get_current_queue() is called on the main thread, it may or may not return the same value as dispatch_get_main_queue(). Comparing the two is not a valid way to test whether code is executing on the main thread.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… is not only deprecated since iOS6, but unreliable according to queue.h
When dispatch_get_current_queue() is called on the main thread, it may or may not return the same value as dispatch_get_main_queue(). Comparing the two is not a valid way to test whether code is executing on the main thread.