Repository navigation
Migrate minimal client command dispatcher - #10
Conversation
|
not implement /connect |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 50f954ebe7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ]; | ||
|
|
||
| fn handle_prompt(ctx: &mut Ctx, prompt: &str) { | ||
| let input = prompt.trim(); |
There was a problem hiding this comment.
Preserve whitespace in regular chat messages
For any regular message with leading or trailing whitespace, trim() changes the bytes sent to the server even though the unmodified line has already been appended to the sender's chat history. For example, entering hello displays that exact text locally but sends hello to peers, so transcripts diverge and whitespace-sensitive messages cannot be sent. Use a trimmed view only for command parsing and write the original prompt for non-command input.
Useful? React with 👍 / 👎.
|
good job |
Summary
/help,/quit, and/disconnectValidation
Closes #3