fix(pfs0): add .js extensions to relative imports for Node ESM#42
Merged
Conversation
The package is "type": "module" but tsc (moduleResolution: Bundler) emitted extensionless `import './types'`, which Node's ESM loader rejects with ERR_MODULE_NOT_FOUND. Add explicit .js extensions to the source imports so the published dist resolves cleanly under Node.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: fc0b041 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@tootallnate/pfs0is"type": "module", but its emitteddist/index.jsimported./typeswithout a.jsextension. Node's ESM loader requires explicit extensions, so importing the published package throwsERR_MODULE_NOT_FOUND..jsextensions to the relative imports insrc/index.tsso the emitted dist resolves cleanly under Node ESM.Why
Hit while consuming
@tootallnate/pfs0from a plain Node script (sys-autopilot's NSZ installer).ncz/zstd-wasmare unaffected because they have no relative imports;pfs0is the only package importing a sibling module.Verification
node -e "import('@tootallnate/pfs0')"now resolves (decode/encodeexported) instead of throwing.