Fix bug in parsing the values section of PSFBIN files#2
Open
jonnykl wants to merge 2 commits intoToonBettens:mainfrom
Open
Fix bug in parsing the values section of PSFBIN files#2jonnykl wants to merge 2 commits intoToonBettens:mainfrom
jonnykl wants to merge 2 commits intoToonBettens:mainfrom
Conversation
Contributor
Author
|
I figured out that Spectre creates such simulation output files with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The binary PSF parser is unable to parse another file generated from a transient simulation with Spectre 23.1.0.802.isr17. The
value_section_typeis 768 which is not defined in the corresponding enum. The type of the values section should be SIMPLE but the section also containsGROUP_DECLARATIONchunks which are currently not handled.Where did you find the information about the
value_section_typefield in the PSFBIN file? Is there any further information for the value 768? I couldn't find anything the C++ libpsf library (which is the reference for this lib?). However, it checks whether there is the sweeps section and whether a specific key in the header is present to decide how the values section has to be parsed. I adapted it from the libpsf library. This change doesn't break any of the tests in this lib.This change alone is not sufficient to parse my file because it contains
GROUP_DECLARATIONchunks in the values section. It looks like the structure of the following data is the same as for theDECLARATIONchunks. Therefore I think the data should be added to all declarations within the group. I'm unsure whether group declaration can be nested or not. My implementation assumes they are not nested.I tried loading the file with the libpsf library. I doesn't throw an error during loading/parsing, but it's not possible the access all signals, i.e.
psf.get_signal(psf.get_signal_names()[1])fails (there are way more than 2 signals). I didn't trace the error back to its origin, but it might be related.Unfortunately, I can't share the simulation output file. However, I will try to reproduce it independent of my work so I can add it to the tests.
Btw, great work, thanks for publishing your lib!