Repository navigation
Weekly tab from a typed weekly data file - #66
Merged
Merged
Conversation
Decision 027: what public/weekly.json holds (multipliers, Weekly Challenge, rotations, discounts, gifts), what it leaves out (GTA+, daily map-bound items), explicit UTC start/end per week, gta.wiki as the source and the routine's run time. Handoff for building the schema, tab and news bar. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Deploying lsos with
|
| Latest commit: |
1525be5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0cc38c71.lsos-2qs.pages.dev |
| Branch Preview URL: | https://claude-16-weekly-events.lsos-2qs.pages.dev |
…#16) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The week lives in src/data/weekly.ts, typed by Week in lib/weekly.ts and checked by a unit test (weekProblems), so verify rejects a bad week. The Weekly tab shows bonus payouts (owned first), challenge and gifts, the rotation, discounts and a collapsed "Also running" list; the Breaking News bar scrolls the bonuses and gifts on every tab and says when the week is out of date. First week: Halloween 2026 (Week 3) from gta.wiki. Guide for writing a week by hand in docs/weekly-update.md; handoff removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ToothyDev
changed the title
ToothyDev
marked this pull request as ready for review
October 15, 2026 16:39
The ticker on every tab was more distracting than helpful; the weekly events now live on the Weekly tab only. The tab gets a header with dates, a status pill (live with time left, or out of date) and the sources; bonus payouts as factor badges next to the challenge and gifts; rotation and discounts as labelled blocks of chips, discounts grouped by kind and percentage. An ended week stays readable, greyed under a warning. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ToothyDev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Shows this week's GTA Online events on the Weekly tab, copied from the gta.wiki weekly event page (decision 027).
src/data/weekly.ts(WEEK, typed byWeekinsrc/lib/weekly.ts). Most entries are plain strings as the wiki words them. Only what the tab sorts or groups by has fields: a multiplier's factor and optional property id, and a discount's kind and percent. There is no JSON, fetch or runtime validator: the type checker plus a unit test (weekProblems: dates in order, sane numbers, known property ids, gta.wiki source) makenpm run verifyreject a bad week. This replaces thepublic/weekly.jsonthe issue named.endhas passed, the pill says "Out of date", a warning says the events are last week's, and the old week stays readable below it, greyed out.start/end, written as Thursday 2:00 AM US Pacific (09:00 UTC in US daylight saving time, 10:00 UTC otherwise).docs/weekly-update.md.Closes #16
How to check it
Checklist
npm run verifypasses🤖 Generated with Claude Code