Open
Conversation
Closed
Closed
Merged
These are the compiler flags used by libtopotoolbox. SWT will need to compile cleanly in order to be merged into libtopotoolbox, so we must resolve any compiler errors and warnings before moving forward. I have set the compiler to error on any warnings, which is somewhat strict, but will help us catch issues early on. We set the flags in the CI workflow, not in the Makefile, to allow consumers of this package to choose the appropriate flags. This way one can still develop SWT in the presence of compiler warnings, but you won't be able to contribute PRs until the compiler warnings are resolved and the PR checks pass. Signed-off-by: William Kearney <william.kearney@uni-potsdam.de>
wkearn
force-pushed
the
set-compiler-warnings
branch
from
28852b4 to
a312538
Compare
Signed-off-by: William Kearney <william.kearney@uni-potsdam.de>
with the -k option make keeps trying to build files until a target can't be made. This should allow us to see errors from both swt.c and find_seamounts.c. Previously, errors in swt.c would halt compilation and hide any errors that might still exist in find_seamounts.c Signed-off-by: William Kearney <william.kearney@uni-potsdam.de>
Member
Author
|
Hi John (@jkhillier), I forgot that the tests that ran on your PR (#8) didn't have the full set of compiler warnings turned on, so a few more unused variable warnings showed up after I merged #8. I went ahead and removed the unused variables, but before I merge this one, you might want to look at the changes https://github.com/TopoToolbox/SWT/pull/4/changes to make sure that nothing was changed that shouldn't have been. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are the compiler flags used by libtopotoolbox. SWT will need to compile cleanly in order to be merged into libtopotoolbox, so we must resolve any compiler errors and warnings before moving forward. I have set the compiler to error on any warnings, which is somewhat strict, but will help us catch issues early on.
We set the flags in the CI workflow, not in the Makefile, to allow consumers of this package to choose the appropriate flags. This way one can still develop SWT in the presence of compiler warnings, but you won't be able to contribute PRs until the compiler warnings are resolved and the PR checks pass.