Add srtm_bigtujunga30m_utm11 data and updated Roxygen2#56
Merged
ktlenz merged 2 commits intoTopoToolbox:mainfrom Dec 3, 2025
Merged
Add srtm_bigtujunga30m_utm11 data and updated Roxygen2#56ktlenz merged 2 commits intoTopoToolbox:mainfrom
ktlenz merged 2 commits intoTopoToolbox:mainfrom
Conversation
Contributor
Author
|
@wkearn I do not quite get why the macos check is failing, would you mind having a look? |
Member
|
I reran the tests for your most recent pull request, and they fail now (https://github.com/TopoToolbox/topotoolboxr/actions/runs/19281458575/job/56901339783), though they passed originally. This is almost certainly something that has changed with terra between versions 1.8.80, which the previous tests used earlier, and 1.8.86, which the tests are now using. I think we may need to explicitly install GDAL and PROJ on macos. I'll mess around with the CI configuration and see if that fixes things. |
Member
|
#57 should fix the errors here. Merge/rebase the main branch into your feature branch and see if the tests work. |
d17ba0d to
873b15d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds the 30 m SRTM elevation data of the Big Tujunga catchment, including documentation and tests.
New dataset:
srtm_bigtujunga30m_utm11ininst/extdataanddata, which provides the SRTM elevation data TIFF as a path for the Big Tujunga catchment.srtm_bigtujunga30m_utm11inR/data.Rusing `Roxygen2 .Testing:
tests/testthat/test-data.Rto verify that the dataset loads correctly, the file exists, and can be used to create aGRIDobj.Metadata update:
RoxygenNoteversion inDESCRIPTIONto 7.3.3.