Skip to content

Add srtm_bigtujunga30m_utm11 data and updated Roxygen2#56

Merged
ktlenz merged 2 commits intoTopoToolbox:mainfrom
ktlenz:feature_TT3data
Dec 3, 2025
Merged

Add srtm_bigtujunga30m_utm11 data and updated Roxygen2#56
ktlenz merged 2 commits intoTopoToolbox:mainfrom
ktlenz:feature_TT3data

Conversation

@ktlenz
Copy link
Copy Markdown
Contributor

@ktlenz ktlenz commented Dec 1, 2025

This pull request adds the 30 m SRTM elevation data of the Big Tujunga catchment, including documentation and tests.

New dataset:

  • Added srtm_bigtujunga30m_utm11 in inst/extdata and data, which provides the SRTM elevation data TIFF as a path for the Big Tujunga catchment.
  • Added corresponding documentation for srtm_bigtujunga30m_utm11 in R/data.R using `Roxygen2 .

Testing:

  • Added a test in tests/testthat/test-data.R to verify that the dataset loads correctly, the file exists, and can be used to create a GRIDobj.

Metadata update:

  • Updated the RoxygenNote version in DESCRIPTION to 7.3.3.

@ktlenz ktlenz added the enhancement New feature or request label Dec 1, 2025
@ktlenz
Copy link
Copy Markdown
Contributor Author

ktlenz commented Dec 1, 2025

@wkearn I do not quite get why the macos check is failing, would you mind having a look?

@wkearn
Copy link
Copy Markdown
Member

wkearn commented Dec 2, 2025

I reran the tests for your most recent pull request, and they fail now (https://github.com/TopoToolbox/topotoolboxr/actions/runs/19281458575/job/56901339783), though they passed originally.

This is almost certainly something that has changed with terra between versions 1.8.80, which the previous tests used earlier, and 1.8.86, which the tests are now using. I think we may need to explicitly install GDAL and PROJ on macos. I'll mess around with the CI configuration and see if that fixes things.

@wkearn
Copy link
Copy Markdown
Member

wkearn commented Dec 3, 2025

#57 should fix the errors here. Merge/rebase the main branch into your feature branch and see if the tests work.

@ktlenz ktlenz merged commit a58a69d into TopoToolbox:main Dec 3, 2025
3 checks passed
@ktlenz ktlenz deleted the feature_TT3data branch December 3, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants