Open
Conversation
Resolves TopoToolbox#40 This PR adds 1. A binding for libtopotoolbox's `excesstopography_fsm2d` 2. An R function `excesstopography` 3. A test of `excesstopography` As in MATLAB/Python, `excesstopography` accepts either a GRIDobj or a scalar for the threshold_slope parameter. No real validation, such as checking the alignment the DEM and the threshold slope, is performed. The test checks that excesstopography runs successfully and validates that the reconstructed topography lies below the supplied DEM. Signed-off-by: William Kearney <william.kearney@uni-potsdam.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #40
This PR adds
excesstopography_fsm2dexcesstopographyexcesstopographyAs in MATLAB/Python,
excesstopographyaccepts either a GRIDobj or a scalar for the threshold_slope parameter. No real validation, such as checking the alignment the DEM and the threshold slope, is performed.The test checks that excesstopography runs successfully and validates that the reconstructed topography lies below the supplied DEM.
@ktlenz: I thought I would try to remind myself how the R stuff works by implementing the excess topography wrapper. Would you mind taking a look and seeing if there is anything I should do differently? I know you're reconfiguring the GRIDobj interface a little bit, and we can wait to merge this until that's done if you'd like.