Replace flow_accumulation_edgelist with traverse_down_f32_add_mul#70
Open
wkearn wants to merge 1 commit intoTopoToolbox:mainfrom
Open
Replace flow_accumulation_edgelist with traverse_down_f32_add_mul#70wkearn wants to merge 1 commit intoTopoToolbox:mainfrom
wkearn wants to merge 1 commit intoTopoToolbox:mainfrom
Conversation
Resolves TopoToolbox#67 See TopoToolbox/libtopotoolbox#212 libtopotoolbox intends to deprecate and remove `flow_accumulation_edgelist` in favor of the flow algebra `traverse_down_f32_add_mul`. This PR wraps the traverse function and modifies `flow_accumulation` to use the latter. The main change in R code is that the output argument is initialized with the input weights instead of requiring a separate output array to be allocated. I also renamed `wrap_flow_accumulation.c` to `wrap_streamquad.c` to match the libtopotoolbox naming. I assume we could add other functions from libtopotoolbox's `streamquad.c` to this file. The existing flow accumulation tests should still pass with this change. Signed-off-by: William Kearney <william.kearney@uni-potsdam.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #67
See TopoToolbox/libtopotoolbox#212
libtopotoolbox intends to deprecate and remove
flow_accumulation_edgelistin favor of the flow algebratraverse_down_f32_add_mul. This PR wraps the traverse function and modifiesflow_accumulationto use the latter.The main change in R code is that the output argument is initialized with the input weights instead of requiring a separate output array to be allocated.
I also renamed
wrap_flow_accumulation.ctowrap_streamquad.cto match the libtopotoolbox naming. I assume we could add other functions from libtopotoolbox'sstreamquad.cto this file.The existing flow accumulation tests should still pass with this change.