feat: throw if 3 parameters in auctions are passed#177
feat: throw if 3 parameters in auctions are passed#177jbergstroem wants to merge 1 commit intomainfrom
Conversation
anonvt
left a comment
There was a problem hiding this comment.
My concern with this approach is if someone just version bumps their app and continue to fail silently because they're not handling errors properly/are too lax (the customer using this didn't pick up on the 400s so they might not pick up on this as well)
How is the outcome different tho? No ads returned. |
|
I've combined your runtime check with the safe typing of the previous PR #176
I expect to break in compile time when they version bump so they actually fix the issue |
Changed the logic to validate and throw if all three params are passed. This makes assumptions but at least stops the user from doing things that the server will fail either way.
Note: used claude to write tests