fix(bank): increase FilterDimensions min height to reject stray pixels#116
Merged
Garrett3Nelson merged 1 commit intoTorwent:masterfrom Mar 7, 2026
Merged
fix(bank): increase FilterDimensions min height to reject stray pixels#116Garrett3Nelson merged 1 commit intoTorwent:masterfrom
Garrett3Nelson merged 1 commit intoTorwent:masterfrom
Conversation
Stray pixels on bank buttons (e.g. after DepositAll) can match the separator color CTS0($232B2E, 5) and pass FilterDimensions(0, 0, 2, 32) as 1x1 clusters. This causes all four Get*Section() methods to fail since they require exactly 3 separators. Raising the minimum height from 0 to 20 filters out stray pixels while keeping the real 1x29 separator lines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stray pixels on bank buttons (e.g. after DepositAll) can match the separator color CTS0($232B2E, 5) and pass FilterDimensions(0, 0, 2, 32) as 1x1 clusters. This causes all four Get*Section() methods to fail since they require exactly 3 separators.
Raising the minimum height from 0 to 20 filters out stray pixels while keeping the real 1x29 separator lines.
BEFORE:
AFTER:
