fix(magic): lower ARCEUUS_COLOR detection threshold from 81 to 60#117
Open
orkabyte wants to merge 1 commit intoTorwent:masterfrom
Open
fix(magic): lower ARCEUUS_COLOR detection threshold from 81 to 60#117orkabyte wants to merge 1 commit intoTorwent:masterfrom
orkabyte wants to merge 1 commit intoTorwent:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The ARCEUUS_COLOR detection threshold of 81 is too high, causing the Arceuus spellbook to be misidentified as Standard.
Testing shows the Arceuus spellbook only produces a color count of 71, which falls below the current threshold of 81. All other spellbooks correctly return 0 for ARCEUUS_COLOR, so lowering the threshold to 60 is safe.
Test Results
With the threshold at 81, the Arceuus spellbook (count 71) fails detection and falls through to Standard.
Lowering the threshold to 60 fixes this while maintaining a safe margin above the next highest false-positive (29 from Lunar).