fix(magic): correct Magic.CountSpells()#262
Open
orkabyte wants to merge 1 commit intoTorwent:masterfrom
Open
Conversation
Add colors for Minigame Teleport, Home Teleport cooldown, and Arceuus Home Teleport cooldown spell icons.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Some spell icon colors were missing, causing
Magic.CountSpells()to return incorrect values:Changes
Testing Results
Minigame Teleport
Standard
BEFORE → 70 spells
AFTER → 69 spells
Ancient
BEFORE → 28 spells
AFTER → 27 spells
Lunar
BEFORE → 47 spells
AFTER → 46 spells
Arceuus
BEFORE → 47 spells
AFTER → 46 spells
Home Teleport Cooldown
BEFORE → 68 spells
AFTER → 69 spells
Arceuus Teleport Cooldown
BEFORE → 45 spells
AFTER → 46 spells
