Skip to content

fix: SettingsHandler magic filter fixes #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Baconadors wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: SettingsHandler magic filter fixes #263

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions osr/handlers/settingshandler.simba
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,15 +446,15 @@ function TSettingsHandler.DisableMagicFilters(out actionsTaken: Int32): Boolean;
var
button: TRSButton;
begin
Self.DebugLn('DisableMagicFilters -> Attempting to disable magic filters');
if not Magic.OpenFilters() then
begin
Self.DebugLn('DisableMagicFilters -> Failed to open magic filters');
Exit;
end;
Self.DebugLn('DisableMagicFilters -> Checking magic filters');
if not Magic.IsFiltered() then
begin
Self.DebugLn('DisableMagicFilters -> No filters active');
Exit(True);
end;
if not Magic.OpenFilters() then
begin
Self.DebugLn('DisableMagicFilters -> Failed to open magic filters');
Exit;
end;
for button in Magic.GetFilterButtons() do
Expand All @@ -466,9 +466,10 @@ begin
Inc(actionsTaken);
end;
end;
Result := WaitUntil(Magic.CloseFilters(), 400, 3000);
end;

Self.DebugLn('DisableMagicFilters -> ' + ToStr(actionsTaken) + ' filter(s) disabled, closing panel');
Magic.CloseFilters();
Result := WaitUntil(not Magic.IsFiltered(), 300, 3000);
end;
(*
## SettingsHandler.FixScreenPostResolutionChange()
```pascal
Expand Down