fix: crystal shards -> crystal shard#43
Closed
SaffatHasan wants to merge 1 commit intoTorwent:masterfrom
Closed
Conversation
Remove typo, fixes banking of crystal shards
Owner
|
So... This is actually not right. I'll be taking a better look at this some day and it is going to take me some time, but "crystal shard" is the name and up text of a single shard, it is the uptext the game uses when you hover shards and the item name the wiki uses but it represents only a single shard while "crystal shards", according to the game cache is what represents all versions of the shards. you can confirm yourself it yourself: {$I SRL-T/osr.simba}
procedure TRSItemFinder.Show(item: TRSItem);
var
display, img: TMufasaBitmap;
i, h, w, x: Integer;
begin
display.Init();
for img in Self.GetItemImages(item) do
begin
if img.GetHeight() > h then h:= img.GetHeight();
w := img.GetWidth();
x := display.GetWidth();
display.SetSize(x+w, h);
display.DrawBitmap(img,[x,0]);
end;
display.Debug();
display.Free();
end;
begin
ItemfInder.Show('Crystal shards');
Wait(5000);
ItemfInder.Show('Crystal shard');
end.Thanks for bringing this up tho, it can cause issues with stuff that relies on the item name like banking indeed, but that has to be fixed in banking not by changing the item name or you will only be able to find a single crystal shard and never multiple. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove typo, fixes banking of crystal shards
https://oldschool.runescape.wiki/w/Crystal_shard