Skip to content
This repository was archived by the owner on Mar 1, 2023. It is now read-only.

update template project - #41

Open
petropavel13 wants to merge 1 commit into
masterfrom
feature/update_template_project
Open

petropavel13 wants to merge 1 commit into
masterfrom
feature/update_template_project

Conversation

@petropavel13

Copy link
Copy Markdown
Contributor

No description provided.


end

# fixes Xcode 12 warnings:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ENV['COCOAPODS_DISABLE_STATS'] = "true"

  • это еще актуальная штука?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

может уже и нет. что-то я по коду в их репозитории нашёл только тесты или типа того


# Utils
pod 'LeadKit'
pod 'DeviceKit'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

почему что-то переехало в spm, а что-то так и осталось в кокоаподс?

@@ -21,22 +21,9 @@ target '{{project_name}}' do
pod 'Firebase/Performance'
pod 'Firebase/Analytics' # for Firebase/Performance

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

берем аналитику без ad id


- name: API Generator
script: . build-scripts/xcode/build_phases/api_generator.sh 1.4.0-alpha3 {{project_name}}/Generated
script: #. build-scripts/xcode/build_phases/api_generator.sh 1.4.0-alpha3 {{project_name}}/Generated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

почему закоменчено?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

новые проекты без api-generator. во всяком случае в текущем виде и если есть swagger

@@ -70,13 +90,13 @@ aggregateTargets:
buildScripts:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Во всех местах билдфаз вызывается install_env.sh, где это необходимо?

@@ -90,34 +110,37 @@ aggregateTargets:
readonly PODS_ROOT="${SRCROOT}/Pods"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А скрипты CodeGen и CodeLint обновлены для работы с воркспейсами?

@petropavel13

Copy link
Copy Markdown
Contributor Author

Надо добавить вызов install_env.sh в CodeGen и CodeLint

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants