Duplicated Stopovers

[DRSchlaubi]

Are you sure this is not a data issue?

• Yes, this is a Traewelling software bug (not a data issue).

Have you checked for existing issues?

• Yes, I have verified that no existing issue covers this problem.

Affected URL (if any)

No response

Describe the problem

For some trips stopovers seem to be duplicated, seems to happen between Basel and Mannheimt a lot, but it also occurred on the S6 of the S-Bahn munich for me

Steps to reproduce

https://traewelling.de/api/v1/stopovers/8167523
https://api.transitous.org/?tripId=20260715_14%3A24_de-DELFI_3288192754

Stopover planegg is duplicated

Expected behavior

No response

Environment

No response

Browser console / error messages (optional)

Additional info (optional)

No response

[DRSchlaubi]

I tried reproducing this locally, but it seems like this only happens on the production server

[DRSchlaubi]

After looking into this further it looks like DELFI returns platform "S-Mue" for trips with realtime data and "1" for trips without it is unclear why this would cause two stopovers though

[MrKrisKrisu]

First the stop was reported with de-DELFI_de:09184:2600:1:1_G, six minutes after the checkin / trip creation with de-DELFI_de:09184:2600:21:21. And because the data in our local database is not matched very well the identifiers are splitted in two stations... (I merged the two objects now into one)

[MrKrisKrisu]

I'm not entirely sure what we can do here (other than improving our data quality, but that's an endless task and involves a lot of manual work).

Maybe we could remove the StationID from the matching process and, when updating, only match based on trip_id and planned_times.

Right now, I can’t think of any edge cases that would break as a result. I’ve already finished the PR for this, but I won’t merge it just yet in case anyone has any vetoes.

[DRSchlaubi]

Sorry for getting back to this so late, I completely forgot about this, rn the stop "Planegg" seems to be missing in general from the trip I shared

[MrKrisKrisu]

Please provide some more information about what we can debug here.

[DRSchlaubi]

On this stopover list after stopover 1084027738 there should be one for Planegg but there isn't.

I don't really understand why it would be missing rn, maybe you could look at all stopovers with that tripid and look for one that is still there but not shown

[MrKrisKrisu]

Do you have a current example? I would like to reproduce the error.
If yoo just like to correct your old trip you can copy and edit it.

[DRSchlaubi]

Sadly I do not, I will comment on this thread once I have another example