Repository navigation
Add Warsaw, Koleje Mazowieckie and PKP Intercity - #27
Merged
Merged
Conversation
kasmar00
changed the title
Contributor
Author
|
Hi, @MrKrisKrisu (sorry for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds:
PKP Intercity-Polskie Koleje Państwowe (PKP)is a parent company that only owns station buildingsMy recent checkins to PKP Intercity trains (ex. https://traewelling.de/status/6646736) and Warsaw Public Transport (ex. https://traewelling.de/status/6703164) both return
operator: nullfromhttps://traewelling.de/api/v1/status/*. Am I thinking right, that adding them here would fix that?If so, how about Koleje Dolnośląskie (ex. https://traewelling.de/status/6646229), which aren't in this repo, but operator is filled properly in traewelling?
And btw. traewelling shows multiple entries for PKP Intercity (in manual trip creation), maybe this is the root problem?:
