Relax MCP Accept-header negotiation and update tests; ensure lockfile sync#40
Closed
Trailgenic wants to merge 2 commits into
Closed
Relax MCP Accept-header negotiation and update tests; ensure lockfile sync#40Trailgenic wants to merge 2 commits into
Trailgenic wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
Author
|
closing. superseded by PR 41 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
npm cisucceeds by verifying the lockfile is synchronized with package.json changes.Description
REQUIRED_ACCEPT_TYPEScheck withhasCompatibleAcceptTypeinapp/mcp/route.tsto accept empty/missingAccept,*/*,application/json, ortext/event-streamand return a 406 only for incompatible values.tests/mcp.test.tsassertions so empty, JSON, SSE, and wildcardAcceptvalues are accepted (useassert.notEqualagainst 406) whiletext/plainremains rejected.lib/ella-registry.tscontinues to advertise both2025-11-25and2025-06-18, so support for the newer MCP protocol is already present and no further protocol-negotiation code changes were necessary.npm install --package-lock-only --no-audit --no-fundto check lockfile status and found the lockfile already synchronized (no lockfile diff to commit).Testing
npm install --package-lock-only --no-audit --no-fundcompleted successfully locally.npm cicould not complete in this environment due to registry fetch failures (EAI_AGAIN), so a full dependency install did not finish and subsequent automated steps could not run to completion.npm run lintcould not complete here because ESLint and other tools could not be resolved from an incompletenode_modules; please re-run the repository CI verify workflow on the PR to confirmnpm ci,lint,typecheck,test, andbuildall pass in GitHub Actions.Codex Task