Skip to content

Relax MCP Accept-header negotiation and update tests; ensure lockfile sync#40

Closed
Trailgenic wants to merge 2 commits into
mainfrom
codex/fix-ci-failures-in-pr-#36
Closed

Relax MCP Accept-header negotiation and update tests; ensure lockfile sync#40
Trailgenic wants to merge 2 commits into
mainfrom
codex/fix-ci-failures-in-pr-#36

Conversation

@Trailgenic

Copy link
Copy Markdown
Owner

Motivation

  • Ensure CI npm ci succeeds by verifying the lockfile is synchronized with package.json changes.
  • Relax strict Accept-header checking in the MCP POST route to maximize agent compatibility for JSON and SSE clients.
  • Preserve MCP protocol compatibility by confirming the registry still advertises the newer protocol version.

Description

  • Replace the strict REQUIRED_ACCEPT_TYPES check with hasCompatibleAcceptType in app/mcp/route.ts to accept empty/missing Accept, */*, application/json, or text/event-stream and return a 406 only for incompatible values.
  • Update tests/mcp.test.ts assertions so empty, JSON, SSE, and wildcard Accept values are accepted (use assert.notEqual against 406) while text/plain remains rejected.
  • Verified lib/ella-registry.ts continues to advertise both 2025-11-25 and 2025-06-18, so support for the newer MCP protocol is already present and no further protocol-negotiation code changes were necessary.
  • Ran npm install --package-lock-only --no-audit --no-fund to check lockfile status and found the lockfile already synchronized (no lockfile diff to commit).

Testing

  • npm install --package-lock-only --no-audit --no-fund completed successfully locally.
  • npm ci could not complete in this environment due to registry fetch failures (EAI_AGAIN), so a full dependency install did not finish and subsequent automated steps could not run to completion.
  • npm run lint could not complete here because ESLint and other tools could not be resolved from an incomplete node_modules; please re-run the repository CI verify workflow on the PR to confirm npm ci, lint, typecheck, test, and build all pass in GitHub Actions.

Codex Task

@vercel

vercel Bot commented Jul 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ellaentity Ready Ready Preview, Comment Jul 14, 2026 12:28am

Request Review

@Trailgenic

Copy link
Copy Markdown
Owner Author

closing. superseded by PR 41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant