Added new login (choose between pre-v6.43 and post-v6.43 (post-v6.43 by default))

[nunokisc]

No description provided.

[bycaldr]

It would be great to merge and publish this fix. Today is this libary almost unusable without support of new login API 🙏

[khertg]

@nunokisc Hi how can I use this fix ?

Below are my dependencies

  "dependencies": {
    "core-decorators": "^0.20.0",
    "mikronode": "^2.3.11",
    "rxjs": "^5.3.0"
  }

And heres my sample code.

connection.connect(function(conn) {

   conn.closeOnDone(true);
   var chan2=conn.openChannel(2);
   chan2.write('/interface/listen',function(chan) {
      chan.on('read',function(data) {
         packet=api.parseItems([data])[0];
         console.log('Interface change: '+JSON.stringify(packet));
      });
   });
});

And got this error

internal/timers.js:361
    throw new ERR_OUT_OF_RANGE(name, 'a non-negative finite number', msecs);
    ^

RangeError [ERR_OUT_OF_RANGE]: The value of "msecs" is out of range. It must be a non-negative finite number. Received NaN
�[90m    at getTimerDuration (internal/timers.js:361:11)�[39m
�[90m    at Socket.setStreamTimeout [as setTimeout] (internal/stream_base_commons.js:227:11)�[39m
    at SocketStream.setTimeout (E:\Projects\mikrotek-test\node_modules\�[4mmikronode�[24m\dist\mikronode.js:577:32)
    at new SocketStream (E:\Projects\mikrotek-test\node_modules\�[4mmikronode�[24m\dist\mikronode.js:550:15)
    at MikroNode.connect (E:\Projects\mikrotek-test\node_modules\�[4mmikronode�[24m\dist\mikronode.js:330:30)
    at Object.<anonymous> (E:\Projects\mikrotek-test\index.js:5:12)
�[90m    at Module._compile (internal/modules/cjs/loader.js:959:30)�[39m
�[90m    at Object.Module._extensions..js (internal/modules/cjs/loader.js:995:10)�[39m
�[90m    at Module.load (internal/modules/cjs/loader.js:815:32)�[39m
�[90m    at Function.Module._load (internal/modules/cjs/loader.js:727:14)�[39m {
  code: �[32m'ERR_OUT_OF_RANGE'�[39m
}

[nunokisc]

This fix is only for the login issue. The login method change on v6.43.
As i can see your error is in another place.
It looks like you have a NaN in some "timer".

[xeleniumz]

I don't have permission to approve your commit , My permission is maintainer may be we should have to fork this project because the maintainer didn't update project for a long time.

[Habbiton]

Any news on this fix? It's almost mandatory on 07/2021

[DevilMorgan]

22 Ağu 2021 Paz 12:54 tarihinde fajarnurprasetyo ***@***.***> şunu yazdı:

…

***@***.**** approved this pull request. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#97 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQ4GCCG3TFGCOG2TFZM6UR3T6DCM7ANCNFSM4KMCT7QA> .

[imPPLs]

Guys! If you wanna fix connection with mikrotik via API:

https://help.mikrotik.com/docs/display/ROS/API:
Login method post-v6.43:

• Now the client sends a username and password in the first message.
• Password is sent in plain text.
• in case of error, the reply contains =message=error message.
• In case of a successful login, the client can start to issue commands.

Just open your file /node_modules/mikronode/dist/mikronode.js
Find string №358 in code.
stream.write(["/login", "=name=" + user, "=response=00" + md5.digest("hex")]);
Change string to
stream.write(["/login", "=name=" + user, "=password=" + password, "=response=00" + md5.digest("hex")]);
And after this you can use standard code for connect to your mikrotik via API like this:

var MikroNode = require('mikronode');

var device = new MikroNode('IP');

device.setDebug(MikroNode.DEBUG);

device.connect().then(([login])=>login('username','password')).then(function(conn) {

var chan=conn.openChannel();

chan.write('/ip/address/add',{'interface':'ether1','address':'192.168.1.1'});
chan.on('trap',function(data) {
console.log('Error setting IP: '+data);
});
chan.on('done',function(data) {
console.log('IP Set.');
});
chan.close();
conn.close();
});

My version RouterOS now is 6.47. Hope this helps someone!

[JamesDelfini]

Changing it to post-v6.43 the password will be sent to the network in plain text. As result, this is not good when using Mikrotik API.