fix(ci): visual summary as workflow artifact (immutable releases) - #41
Merged
Merged
Conversation
…ompatible with immutable releases Generate Visual Summary failed with 'Cannot delete asset from an immutable release' when replacing the visual-summary-latest asset. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
🚦 48h Operativity: NO-GO
|
Contributor
🔒 Docker Security AuditStatus: success Resumen Rápido
Acciones si hay problemas
|
Contributor
Contributor
Contributor
|
🚦 48h Operativity: NO-GO
|
Contributor
🔒 Docker Security AuditStatus: success Resumen Rápido
Acciones si hay problemas
|
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The workflow duplicates the PDF upload and retains unnecessary repository write permissions.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Sustituye la publicación en una release inmutable por un artefacto del workflow.
Changes:
- Publica el PDF como artefacto con retención de 30 días.
- Actualiza la notificación de Slack.
| File | Description |
|---|---|
.github/workflows/generate-visual-summary.yml |
Reemplaza el asset de release por un artefacto del workflow. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Por qué
Tras #27,
Generate Visual Summaryya no hace push, pero falla enPublish rolling visual summary release assetconCannot delete asset from an immutable release(run 36476691655). Las immutable releases están activadas en este repo (enabled: true), así que no se puede sustituir el asset de una release "rolling" (visual-summary-latest).Cambio
El PDF se publica como artefacto del workflow (
visual-summary, retención 30 días). No se toca la protección de releases, que es un control de procedencia que conviene mantener. La release históricavisual-summary-latestno se modifica.🤖 Generated with Claude Code