Chat - #9
Open
TrendySloth1001 wants to merge 11 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements comprehensive authentication and user management features for the homeWork platform, adding Google OAuth integration, JWT-based authentication, user signup flows, and supporting infrastructure.
Key Changes:
- Google OAuth 2.0 authentication with Passport.js and JWT token management
- Teacher and student signup workflows with role-based access control
- Legal document management system for privacy policies, terms of service, and help content
- Conversation service enhancements with thought tags for AI responses
- Database schema expansion with User, Teacher, Student, and related models
Reviewed changes
Copilot reviewed 30 out of 31 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
src/shared/lib/passport.ts |
Passport.js configuration for Google OAuth authentication |
src/features/auth/auth.service.ts |
Core authentication business logic including JWT generation and user management |
src/features/auth/auth.controller.ts |
HTTP handlers for OAuth callbacks and profile endpoints |
src/features/auth/auth.routes.ts |
Authentication route definitions with rate limiting |
src/features/auth/middleware/auth.middleware.ts |
JWT verification and role-based access control middleware |
src/features/signup/signup.*.ts |
Teacher and student profile completion after OAuth |
src/features/legal/legal.*.ts |
Legal document CRUD operations for compliance content |
src/shared/config/index.ts |
Added auth configuration and changed default port to 3001 |
src/shared/lib/errors.ts |
New error classes and asyncHandler utility |
src/features/ai/ai.service.ts |
Added thought tags generation for AI responses |
src/features/ai/conversation.service.ts |
Updated to support thought tags and userId field |
src/server.ts |
Added CORS, passport initialization, and new route handlers |
prisma/schema.prisma |
New User, Teacher, Student models with visibility controls |
package.json |
Auth-related dependencies (passport, JWT, cors, rate-limit, firebase) |
public/*.html |
Frontend test pages for auth and signup flows |
|
|
||
| // Pre-fill name if in URL | ||
| const name = urlParams.get('name'); | ||
| const email = urlParams.get('email'); |
There was a problem hiding this comment.
Unused variable email.
Suggested change
| const email = urlParams.get('email'); |
| } | ||
|
|
||
| function displayUserProfile(data) { | ||
| const { user, profile } = data; |
There was a problem hiding this comment.
Unused variable profile.
Suggested change
| const { user, profile } = data; | |
| const { user } = data; |
| getUserProfileService, | ||
| deactivateUserService, | ||
| } from './auth.service'; | ||
| import { AuthenticatedRequest, GoogleProfile, JWTPayload } from './auth.types'; |
There was a problem hiding this comment.
Unused import AuthenticatedRequest.
| import { UserRole } from '@prisma/client'; | ||
| import { verifyTokenService } from '../auth.service'; | ||
| import { UnauthorizedError } from '../../../shared/lib/errors'; | ||
| import { AuthenticatedRequest, JWTPayload } from '../auth.types'; |
There was a problem hiding this comment.
Unused import AuthenticatedRequest.
| }); | ||
|
|
||
| // Create teacher profile | ||
| const teacher = await prisma.teacher.create({ |
There was a problem hiding this comment.
Unused variable teacher.
Suggested change
| const teacher = await prisma.teacher.create({ | |
| await prisma.teacher.create({ |
| }); | ||
|
|
||
| // Create student profile | ||
| const student = await prisma.student.create({ |
There was a problem hiding this comment.
Unused variable student.
Suggested change
| const student = await prisma.student.create({ | |
| await prisma.student.create({ |
we4rw4 Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…used code Co-authored-by: TrendySloth1001 <133957092+TrendySloth1001@users.noreply.github.com>
Co-authored-by: TrendySloth1001 <133957092+TrendySloth1001@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.