Replace wave graph with new cable-length canvas graph sized to main card - #12
Open
TrentIndeed wants to merge 1 commit into
Open
Replace wave graph with new cable-length canvas graph sized to main card#12TrentIndeed wants to merge 1 commit into
TrentIndeed wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
index.htmlwhich implements the new layout, styling, and the canvas-based plot inside the.cardand.graphWrapcontainers.10seconds of samples, usesrequestAnimationFrame, and resizes the canvas for device pixel ratio withresize().#leftand#rightto drive series arrays and update labels (#leftVal,#rightVal), and draw grid lines, tick labels, and thicker colored lines with a glowing lead dot.#chart, 2D context, sliders, and that slider min/max match expected values.Testing
index.htmlwith Playwright, capturing a screenshot of the rendered UI which completed successfully.#chart, 2D context, and slider min/max of0/36) executed in the browser and did not trigger errors.Codex Task