Title: Fix vehicle markers not updating on realtime data change#12
Open
kudlav wants to merge 1 commit intoTriLinder:mainfrom
Open
Title: Fix vehicle markers not updating on realtime data change#12kudlav wants to merge 1 commit intoTriLinder:mainfrom
kudlav wants to merge 1 commit intoTriLinder:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where vehicle markers remained static on the map even when the underlying
realtimeGtfsDataStoreupdated (every 10s). Previously, markers would only update their positions if the user manually panned or zoomed the map.The issue was caused by a race condition in the manual store subscription inside onMount:
This listener was firing before Svelte had propagated the new store value to the component's local
$realtimeGtfsDataStore. SinceupdateMarkers()relies on$realtimeGtfsDataStoreto draw vehicles, it was executing with stale data during the automatic fetch cycle.I replaced the manual
.subscribe()inonMountwith a native Svelte reactive statement:This guarantees that
updateMarkers()runs only after the$realtimeGtfsDataStorevariable has been updated with fresh data.Acceptance