Remove Most Sources of Flash Immunity.

[Nox38]

About the PR

Removed flash immunity from every item except:

• welding mask (the one that covers your helmet slot)
• blindfolds
• space ninja visor, deathsquad gear (No reason to change it and less upstream file changes is always better)
  Also removed the disarming melee attack from hand flash bulbs.

Why / Balance

Currently flashbangs are completely useless, as everyone just is immune to them. This makes flashbangs are interesting option.
This is also realistic- IRL becoming immune to both the audio and visual effects of a flashbang is rather difficult.

Media

Requirements

• I have read Attributing Your Changes and the documentation relevant to this PR.
• I have added media to this PR or it does not require an ingame showcase.
• I can confirm this PR contains either no AI-generated content, or AI-generated content that meets our guidelines.

How to test

Activate a hand flash or flashbang while wearing previously flash immune items like sunglasses.

Breaking changes

Changelog

🆑Nox38

• remove: Removed flash immunity. Flashbangs are dangerous now.
• remove: Removed melee disarm attacks from hand flash bulbs.

[Nox38]

Any idea why that test is failing? Is it important?

[TheRealMasterChief117]

I just redid tests, its not important

[TschudyNF]

What about things that reasonably should have flash protection like the engineering goggles and certain versions of sunglasses?

[BoskiYourk]

What about things that reasonably should have flash protection like the engineering goggles and certain versions of sunglasses?

I'd argue it's an all or nothing sort of deal. Flash immunity is a hard-counter and having hard-counters without drawbacks just makes mechanics non-existent to some, which tends to not feel great.

Personally, I think flashes should maybe be changed some because in some instances they can just be too overwhelming. The 4 gauge flash rounds are a good example, those are part of the reason so many suits got flash protection built in. It's a pain point that shouldn't be ignored, flash spam is real and sucks to fight against.

[Nox38]

What about things that reasonably should have flash protection like the engineering goggles and certain versions of sunglasses?

Reasonably, only goggles and full masks can provide flash immunity, and it would come at a massive hit to visibility. The reason the welding mask gets to keep it is that it prevents you from wearing a helmet, thus impacting your protection- theres no downside to wearing engi goggles as long as hardsuits have built in night vision.

[Nox38]

Personally, I think flashes should maybe be changed some because in some instances they can just be too overwhelming. The 4 gauge flash rounds are a good example, those are part of the reason so many suits got flash protection built in. It's a pain point that shouldn't be ignored, flash spam is real and sucks to fight against.

With this PR, using contact fused flashbang rounds comes at the cost of also flashing yourself with every shot.

[Nox38]

I might potentially be able to whip up a system where certain flash immunity items get to exist (engi/tactical goggles, welding masks) but give you a screen vigent (no idea how to spell that) on par with mid-tier night vision.
If thats a more desirable solution, that is.

[TheRealMasterChief117]

Engineering goggles shouldn't even be welding protection, they're mesons that let you see the layout of rooms. It's only like that as a placeholder because mesons dont exist yet

[rebaserHEAD]

I am iffy on this. Please give the team a bit of time to chew this over, please.