Skip to content

Better Weapon Groups - #619

Open
Nox38 wants to merge 10 commits into
Triad-Sector:mainfrom
Nox38:Better-Weapon-Groups
Open

Nox38 wants to merge 10 commits into
Triad-Sector:mainfrom
Nox38:Better-Weapon-Groups

Conversation

@Nox38

@Nox38 Nox38 commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

About the PR

Redid the gunnery control console's weapon groups to make more sense. Instead of the previous
Ballistics (Only conventional guns, including ones with limited ammo which you need to conserve)
Energy (both hitscan and plasma projectiles, which are aimed differently)
Missiles (including ones with limited ammo which you need to conserve)

its now:
Ballistic (Everything that follows a ballistic trajectory (not hitscan) and has infinite ammo)
image
image

Ballistic - Limited (Anything from the above that needs to be manually reloaded)
image

Impulse (All hitscans)
image
image

Guided (Anything that guides itself to the target, including bomb bays which have the option of either guided or unguided bombs)
image
image

Guided - Limited (Anything from the above that needs to be manually reloaded)
image

Why / Balance

This should make divvying up who operates what weapons when crewing a ship together far easier. No more clicking a weapon group and getting weapons that are fundamentally impossible to aim at the same time as each other. This also clarifies what things you gotta watch the ammo on.

Media

Requirements

  • I have read Attributing Your Changes and the documentation relevant to this PR.
  • I have added media to this PR or it does not require an ingame showcase.
  • I can confirm this PR contains either no AI-generated content, or AI-generated content that meets our guidelines.

How to test

Go in game, spawn a bunch of weapons, and use the console.

Breaking changes

Changed a lot of variable names to reflect the new group names, this could be reverted if maintainers prefer it that way.

Changelog

🆑Nox38

  • tweak: Rebuilt weapon groups to make more sense.

@Nox38

Nox38 commented Sep 6, 2026

Copy link
Copy Markdown
Contributor Author

Setting this as ready for review to get the tests to run, ignore the PR.
...Theres probably a better way to do this than opening a PR, if anyone knows how, let me know

@Nox38
Nox38 marked this pull request as ready for review September 6, 2026 20:31
@Nox38
Nox38 marked this pull request as draft September 6, 2026 20:36
@github-actions github-actions Bot added size/M and removed size/S labels Sep 14, 2026
@Nox38
Nox38 marked this pull request as ready for review September 14, 2026 18:54
@Nox38

Nox38 commented Sep 14, 2026

Copy link
Copy Markdown
Contributor Author

Need a maintainer to tell me a few things:

  1. Do y'all want me to keep all the variable name changes, or would it be better to minimize merge conflicts with Monolith by keeping the names the same? (Impulse staying as Energy in the code, Limited staying as Missile in the code)
  2. Are you interested in more weapon groups being added? Idea was to add sub groups- a low and high velocity group underneath ballistic to assist with aiming, and a guided group containing both limited and infinite ammo guided missiles.

@rebaserHEAD

Copy link
Copy Markdown
Collaborator

Just popping in, please check the wiki on how to appropriately comment your code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants