Repository navigation
fix: upgrade the Stellar SDK - #559
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@stellar/stellar-sdkfrom16.0.1to16.4.1to move past the npm audit affected range.1.20.0, outside the advisory's affected<1.20.0range.SDK compatibility
Reviewed the release notes and API changes from
16.0.1through16.4.1. No breaking API changes affect this project's usage. The 16.1 release notes include Horizon submit error-type changes and Federation error-wrapping changes; this application does not use those APIs. Reviewed transaction construction andTransactionBuilder.fromXDR,StrKeyvalidation,Asset.native().contractId, and the Soroban XDR fixture code. Runtime smoke checks against 16.4.1 passed for these API families, includingnativeToScValand Soroban XDR serialization/deserialization; no application code changes were needed.Validation
npm audit --omit=dev: no@stellar/stellar-sdkor Axios findings remain. The audit still reports 4 high and 1 critical findings in other production dependencies, so the command exits nonzero.vitestmissing).playwrightmissing).npm run lint: unavailable (eslintmissing).npm run typecheck: unavailable (tscmissing).npm test: unavailable (vitestmissing).npm run build: unavailable (nextmissing).npm ci --ignore-scripts --no-audit --no-fund --fetch-timeout=30000 --fetch-retries=0: failed withEIDLETIMEOUTfetching from the npm registry, leaving the dependency installation incomplete. No test failure attributable to the code change was observed.Closes #513