Repository navigation
fix: cover diagnostic contract id conversion - #561
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
xdr.DiagnosticEventto verify the diagnostic contract hash is converted to the expected C-address in the extracted failure string.Bufferconversion that satisfiesStrKey.encodeContractis present in the current base; this change adds regression coverage for its runtime behavior.Closes #499
Validation
npx vitest run lib/contract-confirm.test.tspassed (2 tests).npm run typecheckpassed.npm run lintpassed with 7 existing warnings.NEXT_PUBLIC_MOCK_API=true npm run buildpassed.npm testreported 45 failing tests across 10 files and 911 passing tests; failures are outside the new test file and cover existing app/configuration, fixture, and RPC-mock tests.