Skip to content

fix: make validation messages, lint, test setup, and MCP payloads less error-prone - #179

Merged
yordis merged 7 commits into
mainfrom
yordis/fix-quick-wins
Oct 19, 2026
Merged

yordis merged 7 commits into
mainfrom
yordis/fix-quick-wins

Conversation

@yordis

@yordis yordis commented Oct 19, 2026 •

Copy link
Copy Markdown
Member
  • Agents were sent to fix the wrong thing when a storyboard entry had an observer but no read model, because the finding said the entry was missing entirely.
  • The offline link check failed after pnpm install on links inside dependencies we do not own.
  • Integration tests failed on OrbStack until people discovered they had to export DOCKER_HOST by hand.
  • docs: PR titles kept failing the title check; the allowed types live in the shared action, so contributors need to know to use chore(docs):.
  • Agents naturally pass entity and batch payloads as JSON objects, and having to double-encode them as strings caused avoidable call failures.

Closes #96
Closes #87
Closes #86
Closes #84
Refs #88


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
…HOST

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@cursor

cursor Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

PR Summary

Low Risk
Changes are mostly validation copy, MCP input parsing (backward-compatible strings), link-check exclusions, and local Docker test setup; no auth or persistence behavior changes beyond more precise warning metadata.

Overview
This PR tightens developer and agent ergonomics around validation messaging, CI/dev setup, docs, and MCP JSON arguments.

Storyboard validation refines STORYBOARD_MISSING_ENTRY: instead of always saying the entry is missing, warnings now distinguish no entry, empty entry, missing read model, or missing observer, with matching subject_field paths (entry, entry.read_model, entry.observer).

MCP mutations accept entity_json and request_json as either a JSON object or a JSON-encoded string via a new JsonPayload type; handlers normalize with to_json_text() before size checks and proto parsing. Schemas, unit tests, and an integration test cover the object form; repair docs note the same for batch_mutate_json.

Tooling/docs: lychee skips node_modules/; the Rust test mise task sets DOCKER_HOST from the active Docker context when unset; AGENTS.md documents SemConv PR titles (chore(docs): not docs:).

Reviewed by Cursor Bugbot for commit 579ed3b. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 94a4ea6. Configure here.

Comment thread rsworkspace/crates/trogon-atlas-server/src/validation.rs Outdated
@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 43 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8286f7cc-322f-40b2-b35b-5840be79fb63
📥 Commits

Reviewing files that changed from the base of the PR and between f97cd1a and 579ed3b.

📒 Files selected for processing: 8
  • .config/lychee.toml
  • .config/mise/tasks/github/workflows/ci/rust-test
  • AGENTS.md
  • docs/how-to/repair-validation-findings.md
  • rsworkspace/crates/trogon-atlas-mcp/src/server.rs
  • rsworkspace/crates/trogon-atlas-mcp/src/tools.rs
  • rsworkspace/crates/trogon-atlas-mcp/tests/operation_id_mcp_integration.rs
  • rsworkspace/crates/trogon-atlas-server/src/validation.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@yordis
yordis merged commit 1c33660 into main Oct 19, 2026
28 checks passed
@yordis
yordis deleted the yordis/fix-quick-wins branch October 19, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant