Skip to content

fix(examples): make every example manifest set validate clean - #190

Merged
yordis merged 5 commits into
mainfrom
yordis/fix-example-manifests
Oct 19, 2026
Merged

yordis merged 5 commits into
mainfrom
yordis/fix-example-manifests

Conversation

@yordis

@yordis yordis commented Oct 19, 2026 •

Copy link
Copy Markdown
Member
  • The example manifests are the first thing people apply, and they failed validation with errors and warnings, which taught the wrong shapes.
  • A test now keeps them clean, so a rule change cannot silently break them again.

Closes #97


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
…ection

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@cursor

cursor Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

PR Summary

Low Risk
Changes are example seeds, docs, and an integration test; no production server or validator logic changes.

Overview
Example manifests now pass full Atlas validation, with a regression test so validator changes cannot silently break the seeds again.

Adds example_manifests_validate in trogon-atlas-server: it loads all three examples/manifests/ namespaces into an ephemeral store and asserts no warnings or errors on each EventModel and Project. Docs record baseline findings and the repair playbook now points at this test (plus trogon-atlas fmt / manifests:verify) when fixing seed YAML.

Manifest repairs are behavior-preserving modeling fixes: Projects and domain links; derived timestamps on place-order and submit-review; buyer/seller (and related fields) carried through order events and read models; one read-model slice per order-status source event with slices ordered after emitters; pending-payments-rms moved into checkout-flow after place-order; acme-reviews drops the storefront fulfillment upsert slice from the storyboard/model and removes cross-context given from the grant scenario; storyboard entry read models and Orphan/MixedSurface annotations where warnings are intentional.

Reviewed by Cursor Bugbot for commit ce28978. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented Oct 19, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: fb42ac4a-f249-40cf-8c37-f8fbfdb70b2a
📥 Commits

Reviewing files that changed from the base of the PR and between af7a5ee and ce28978.

📒 Files selected for processing: 24
  • docs/explanation/validation-repair-patterns.md
  • docs/how-to/repair-validation-findings.md
  • examples/manifests/acme-customer-data-deletion/domain.yaml
  • examples/manifests/acme-customer-data-deletion/project.yaml
  • examples/manifests/acme-customer-data-deletion/storyboard.yaml
  • examples/manifests/acme-reviews/command-slice.yaml
  • examples/manifests/acme-reviews/command.yaml
  • examples/manifests/acme-reviews/domain.yaml
  • examples/manifests/acme-reviews/event-model.yaml
  • examples/manifests/acme-reviews/project.yaml
  • examples/manifests/acme-reviews/read-model-slice.yaml
  • examples/manifests/acme-reviews/read-model.yaml
  • examples/manifests/acme-reviews/storyboard.yaml
  • examples/manifests/acme-reviews/ui.yaml
  • examples/manifests/acme-storefront/command.yaml
  • examples/manifests/acme-storefront/domain.yaml
  • examples/manifests/acme-storefront/event-model.yaml
  • examples/manifests/acme-storefront/event.yaml
  • examples/manifests/acme-storefront/persona.yaml
  • examples/manifests/acme-storefront/project.yaml
  • examples/manifests/acme-storefront/read-model-slice.yaml
  • examples/manifests/acme-storefront/read-model.yaml
  • examples/manifests/acme-storefront/storyboard.yaml
  • rsworkspace/crates/trogon-atlas-server/tests/example_manifests_validate.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@yordis
yordis merged commit 74694e1 into main Oct 19, 2026
28 checks passed
@yordis
yordis deleted the yordis/fix-example-manifests branch October 19, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Example manifests fail validate_event_model (14 issues in acme-storefront)

1 participant