Skip to content

fix(server): close CLI, MCP and validation gaps found while repairing models - #192

Merged
yordis merged 6 commits into
mainfrom
yordis/fix-cli-server-gaps
Oct 19, 2026
Merged

yordis merged 6 commits into
mainfrom
yordis/fix-cli-server-gaps

Conversation

@yordis

@yordis yordis commented Oct 19, 2026 •

Copy link
Copy Markdown
Member
  • Mutating MCP tools did not say whether they wrote to a branch or the baseline, so an agent could not confirm where its change landed.
  • A dry-run merge reported one total, hiding deletes and the findings the merge would leave behind.
  • Surveying a namespace needed a Domain or Project scope that many namespaces do not have.
  • Slices without scenarios were invisible, so there was no way to list the behavior still left to specify.

Closes #111
Closes #113
Closes #95
Closes #78


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
…ith its findings

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
…valid

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@cursor

cursor Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

PR Summary

Medium Risk
Changes merge RPC/CLI/MCP response shapes and adds validation behavior (SLICE_NO_SCENARIOS, dry-run findings); clients parsing merge or MCP envelopes may need updates, but persistence semantics stay all-or-nothing.

Overview
This PR tightens review and agent workflows around branches, merges, and namespace-wide validation.

Merge dry runs now return added/changed/deleted counts plus post-merge validation (errors on STATUS_INVALID, warnings/info on a clean STATUS_VALIDATED), so reviewers and the CLI/MCP do not need a separate diff + validate pass. The CLI and JSON output mirror that with severity summaries and structured findings; validation issues in JSON include severity.

MCP mutating tools echo scope (baseline vs branch) and branch on success envelopes so callers can confirm where a write landed without diffing stores.

validate_project gains an exclusive namespace scope (proto, server, MCP, docs) to validate every EventModel in a namespace without a Domain/Project. A new Info rule SLICE_NO_SCENARIOS flags command/read-model/automation slices with no scenarios, supporting bulk triage via namespace validation.

Docs and integration tests cover the new contracts.

Reviewed by Cursor Bugbot for commit feb8cb9. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 17 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: fc4a0b9e-cdd9-4c28-8f3b-c18d681787e3
📥 Commits

Reviewing files that changed from the base of the PR and between af7a5ee and feb8cb9.

⛔ Files ignored due to path filters: 2
  • rsworkspace/crates/trogon-atlas-proto/src/gen/descriptor.binpb is excluded by !**/gen/**
  • rsworkspace/crates/trogon-atlas-proto/src/gen/trogonatlas.api.eventmodel.v1alpha1.rs is excluded by !**/gen/**
📒 Files selected for processing: 17
  • docs/explanation/branching.md
  • docs/how-to/repair-validation-findings.md
  • proto/trogonatlas/api/eventmodel/v1alpha1/service.proto
  • proto/trogonatlas/api/eventmodel/v1alpha1/validation.proto
  • rsworkspace/crates/trogon-atlas-cli/src/main.rs
  • rsworkspace/crates/trogon-atlas-cli/tests/branch_cli_integration.rs
  • rsworkspace/crates/trogon-atlas-client/src/apply.rs
  • rsworkspace/crates/trogon-atlas-client/src/branch.rs
  • rsworkspace/crates/trogon-atlas-mcp/README.md
  • rsworkspace/crates/trogon-atlas-mcp/src/server.rs
  • rsworkspace/crates/trogon-atlas-mcp/src/tools.rs
  • rsworkspace/crates/trogon-atlas-mcp/tests/mutation_scope_mcp_integration.rs
  • rsworkspace/crates/trogon-atlas-mcp/tests/tool_surface_gap_coverage.rs
  • rsworkspace/crates/trogon-atlas-server/src/service.rs
  • rsworkspace/crates/trogon-atlas-server/src/validation.rs
  • rsworkspace/crates/trogon-atlas-server/tests/branching.rs
  • rsworkspace/crates/trogon-atlas-server/tests/handler_tests.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit a7b646e. Configure here.

Comment thread rsworkspace/crates/trogon-atlas-cli/src/main.rs
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@yordis
yordis merged commit b5bc7c6 into main Oct 19, 2026
27 checks passed
@yordis
yordis deleted the yordis/fix-cli-server-gaps branch October 19, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant