[enilsen16]

Problem

apply reports OPEN_QUESTION_PRESENT and ASSUMPTION_PRESENT only for scenario metadata. validate_event_model reports them only for entity metadata. No single call lists all open questions and assumptions in a model.

Change

• Move the scenario annotation walk into one helper, push_scenario_annotation_findings. validate_scenarios (apply) and validate_model both call it, so the two surfaces give the same finding for the same scenario annotation (same message, subject and subject_field: scenarios[].metadata).
• validate_model now reports annotations on the scenarios of each CommandSlice, ReadModelSlice and AutomationSlice member, next to the entity-level annotations.
• validate_model reports the annotations of a member once, also when the model lists that member more than once.

Test

• validate_model reports two OPEN_QUESTION_PRESENT findings for a CommandSlice with an open question on the slice and one on a scenario (metadata and scenarios[].metadata). The scenario finding is equal to the finding that validate_scenarios gives.
• The same check for ASSUMPTION_PRESENT.
• A model that lists the same slice two times gives each finding once.
• cargo test -p trogon-atlas-server and cargo clippy -p trogon-atlas-server --all-targets -- -D warnings pass.

Closes #92

---

^{Need help on this PR? Tag @codesmith-bot with what you need.}

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: a071ee47-1b63-4093-a855-4ed9c49edbb9

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[cursor]

PR Summary

Low Risk
Changes only add informational validation findings and deduplicate reporting; no auth, persistence, or blocking validation behavior.

Overview
validate_event_model now surfaces open questions and assumptions on scenario metadata, so one validation pass can answer what is still open at both entity and scenario level—matching what apply already reported via validate_scenarios.

Scenario annotation handling is centralized in push_scenario_annotation_findings, used by slice validation during apply and by the model-wide member walk. Duplicate model members no longer duplicate Info findings thanks to a per-member dedup set.

Tests assert slice + scenario metadata / scenarios[].metadata findings, parity between validate_model and validate_scenarios for the same scenario annotation, and single reporting when a member is listed twice.

^{Reviewed by Cursor Bugbot for commit fd302bc. Bugbot is set up for automated code reviews on this repo. Configure here.}