Repository navigation
fix(studio): ask the human to settle open questions and assumptions instead of repairing the model - #207
Conversation
…nstead of repairing the model Signed-off-by: Erik Nilsen <enilsen16@live.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PR SummaryLow Risk Overview Structural and other validation codes still get the existing “Fix” wording and the full targeted repair guidance (fetch missing defs, preserve causality, rerun validation, etc.). Implementation splits shared copy into Tests assert both annotation codes get resolve/human wording and omit “targeted repair”, while codes like Reviewed by Cursor Bugbot for commit 6cc98ad. Bugbot is set up for automated code reviews on this repo. Configure here. |
Problem
Studio gives the same fix prompt for every validation finding. For
OPEN_QUESTION_PRESENTandASSUMPTION_PRESENT, the prompt tells the agent to "apply a targeted repair". Nothing in the model is broken for these codes. The prompt pushes the agent to change the model to clear the finding, when only a human can answer the question or confirm the assumption.Change
OPEN_QUESTION_PRESENTandASSUMPTION_PRESENT, the prompt starts with "Resolve this validation finding" and replaces the repair instructions. It says that nothing in the model is broken and that the agent must not change behavior to clear the finding.A
resolve_annotationMCP tool with outcomes and annotation history is not part of this change.Test
validation-context.test.ts: for both annotation codes, the prompt has the resolve wording and does not contain "targeted repair". ForCOMMAND_MULTIPLE_ISSUERS, the prompt still contains "targeted repair".pnpm --filter trogon-atlas-studio test,typecheckandlint.Closes #116
Need help on this PR? Tag
@codesmith-botwith what you need.