Skip to content

chore(docs): show how to repair a problem space declared inside context namespaces - #225

Merged
yordis merged 6 commits into
mainfrom
yordis/chore-docs-problem-space-repair
Oct 23, 2026
Merged

yordis merged 6 commits into
mainfrom
yordis/chore-docs-problem-space-repair

Conversation

@yordis

@yordis yordis commented Oct 21, 2026 •

Copy link
Copy Markdown
Member
  • The repair playbook had no recipe for relocating a problem space, so agents silenced DOMAIN_MISSING_PROJECT by adding a Project and a Domain to every context namespace.
  • The recorded pattern that endorsed per-context problem spaces now contradicts the validator, and future repairs need to know it was superseded and why.

Stack created with GitHub Stacks CLI • Give Feedback 💬


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@cursor

cursor Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

PR Summary

Low Risk
Changes are limited to documentation and example README guidance; no runtime or validator code in this diff.

Overview
Documentation now describes how to repair strategic validation findings by restructuring Acme’s problem space instead of papering over warnings with a Project and Domain in every context namespace.

validation-repair-patterns.md adds the pattern one problem space, contexts realize across namespaces (findings like DOMAIN_IN_CONTEXT_NAMESPACE, REALIZES_MIXED_CLASSIFICATIONS, SEAM_WITHOUT_RELATIONSHIP), documents the split into acme plus acme-storefront / acme-fulfillment, and updates historical acme-reviews notes and superseded “per-namespace Project” guidance. repair-validation-findings.md adds a step-by-step migration (retarget_references, delete_entity, classification splits) and expands MCP mutation response docs (issues array, strategic findings on write). Tutorials and READMEs (start-a-model-from-scratch, run-atlas-locally, examples/manifests/README) now teach applying acme/ first, the new apply order, payment vs fulfillment storyboards, and cross-namespace realizes / event-model membership rules.

Reviewed by Cursor Bugbot for commit 8488152. Bugbot is set up for automated code reviews on this repo. Configure here.

@yordis
yordis added this pull request to stack #227 October 21, 2026 11:45
@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 26 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d38e39cc-d607-40d5-9fe9-cb8152c4f80a
📥 Commits

Reviewing files that changed from the base of the PR and between 55ef11d and edce765.

⛔ Files ignored due to path filters: 1
  • rsworkspace/crates/trogon-atlas-proto/src/gen/trogonatlas.api.eventmodel.v1alpha1.rs is excluded by !**/gen/**
📒 Files selected for processing: 79
  • .config/mise/tasks/compose/restore-drill
  • docs/explanation/validation-repair-patterns.md
  • docs/how-to/repair-validation-findings.md
  • docs/how-to/start-a-model-from-scratch.md
  • docs/tutorials/run-atlas-locally.md
  • examples/manifests/README.md
  • examples/manifests/acme-customer-data-deletion/bounded-context.yaml
  • examples/manifests/acme-customer-data-deletion/domain.yaml
  • examples/manifests/acme-customer-data-deletion/event-model.yaml
  • examples/manifests/acme-customer-data-deletion/project.yaml
  • examples/manifests/acme-customer-data-deletion/subdomain.yaml
  • examples/manifests/acme-fulfillment/automation-slice.yaml
  • examples/manifests/acme-fulfillment/bounded-context.yaml
  • examples/manifests/acme-fulfillment/command-slice.yaml
  • examples/manifests/acme-fulfillment/command.yaml
  • examples/manifests/acme-fulfillment/component.yaml
  • examples/manifests/acme-fulfillment/event-model.yaml
  • examples/manifests/acme-fulfillment/event.yaml
  • examples/manifests/acme-fulfillment/external-system.yaml
  • examples/manifests/acme-fulfillment/persona.yaml
  • examples/manifests/acme-fulfillment/processor.yaml
  • examples/manifests/acme-fulfillment/read-model-slice.yaml
  • examples/manifests/acme-fulfillment/read-model.yaml
  • examples/manifests/acme-fulfillment/storyboard.yaml
  • examples/manifests/acme-fulfillment/swimlane.yaml
  • examples/manifests/acme-fulfillment/tracker.yaml
  • examples/manifests/acme-fulfillment/ui-slice.yaml
  • examples/manifests/acme-fulfillment/ui.yaml
  • examples/manifests/acme-reviews/bounded-context.yaml
  • examples/manifests/acme-reviews/domain.yaml
  • examples/manifests/acme-reviews/event-model.yaml
  • examples/manifests/acme-reviews/project.yaml
  • examples/manifests/acme-reviews/read-model.yaml
  • examples/manifests/acme-reviews/storyboard.yaml
  • examples/manifests/acme-reviews/subdomain.yaml
  • examples/manifests/acme-storefront/automation-slice.yaml
  • examples/manifests/acme-storefront/bounded-context.yaml
  • examples/manifests/acme-storefront/command-slice.yaml
  • examples/manifests/acme-storefront/command.yaml
  • examples/manifests/acme-storefront/component.yaml
  • examples/manifests/acme-storefront/domain.yaml
  • examples/manifests/acme-storefront/event-model.yaml
  • examples/manifests/acme-storefront/event.yaml
  • examples/manifests/acme-storefront/external-system.yaml
  • examples/manifests/acme-storefront/processor.yaml
  • examples/manifests/acme-storefront/project.yaml
  • examples/manifests/acme-storefront/read-model-slice.yaml
  • examples/manifests/acme-storefront/read-model.yaml
  • examples/manifests/acme-storefront/storyboard.yaml
  • examples/manifests/acme-storefront/subdomain.yaml
  • examples/manifests/acme-storefront/swimlane.yaml
  • examples/manifests/acme-storefront/tracker.yaml
  • examples/manifests/acme-storefront/ui.yaml
  • examples/manifests/acme-wishlist/bounded-context.yaml
  • examples/manifests/acme-wishlist/domain.yaml
  • examples/manifests/acme-wishlist/event-model.yaml
  • examples/manifests/acme-wishlist/project.yaml
  • examples/manifests/acme-wishlist/subdomain.yaml
  • examples/manifests/acme/domain.yaml
  • examples/manifests/acme/project.yaml
  • examples/manifests/acme/subdomain.yaml
  • proto/trogonatlas/api/eventmodel/v1alpha1/service.proto
  • rsworkspace/crates/trogon-atlas-cli/README.md
  • rsworkspace/crates/trogon-atlas-cli/src/main.rs
  • rsworkspace/crates/trogon-atlas-cli/tests/branch_cli_integration.rs
  • rsworkspace/crates/trogon-atlas-cli/tests/validate_cli_integration.rs
  • rsworkspace/crates/trogon-atlas-client/src/apply.rs
  • rsworkspace/crates/trogon-atlas-client/src/branch.rs
  • rsworkspace/crates/trogon-atlas-client/src/validate.rs
  • rsworkspace/crates/trogon-atlas-mcp/README.md
  • rsworkspace/crates/trogon-atlas-mcp/src/server.rs
  • rsworkspace/crates/trogon-atlas-mcp/tests/tool_lifecycle_integration.rs
  • rsworkspace/crates/trogon-atlas-server/src/service.rs
  • rsworkspace/crates/trogon-atlas-server/src/validation.rs
  • rsworkspace/crates/trogon-atlas-server/tests/account_deletion_fixture.rs
  • rsworkspace/crates/trogon-atlas-server/tests/branching.rs
  • rsworkspace/crates/trogon-atlas-server/tests/example_manifests_validate.rs
  • rsworkspace/crates/trogon-atlas-server/tests/handler_tests.rs
  • rsworkspace/crates/trogon-atlas-server/tests/strategic_write_validation.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@yordis
yordis force-pushed the yordis/chore-docs-problem-space-repair branch 2 times, most recently from 2ce7066 to 4fc0567 Compare October 21, 2026 12:19
@yordis
yordis force-pushed the yordis/chore-docs-problem-space-repair branch from 4fc0567 to 7befb2f Compare October 21, 2026 12:37
@yordis
yordis force-pushed the yordis/chore-docs-problem-space-repair branch from 7befb2f to f02b9cd Compare October 22, 2026 19:09
@yordis
yordis marked this pull request as ready for review October 22, 2026 19:09
@yordis
yordis force-pushed the yordis/chore-docs-problem-space-repair branch from f02b9cd to 38993a3 Compare October 22, 2026 19:34
…itten

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
…dy stored

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
…xt namespaces

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@yordis
yordis force-pushed the yordis/chore-docs-problem-space-repair branch from 38993a3 to edce765 Compare October 23, 2026 00:58
Base automatically changed from yordis/feat-strategic-validation-findings to main October 23, 2026 01:32
@yordis
yordis merged commit ef9d3de into main Oct 23, 2026
25 of 43 checks passed
@yordis
yordis deleted the yordis/chore-docs-problem-space-repair branch October 23, 2026 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant