Skip to content

fix(types): align execution result metadata with dispatch contract - #77

Merged
yordis merged 1 commit into
mainfrom
yordis/fix-execution-result-metadata-type
Apr 15, 2026
Merged

yordis merged 1 commit into
mainfrom
yordis/fix-execution-result-metadata-type

Conversation

@yordis

@yordis yordis commented Apr 15, 2026

Copy link
Copy Markdown
Member
  • Keeps the execution result typespec aligned with the value actually built from dispatch metadata so static analysis reflects the public API accurately
  • Avoids leaking a misleading struct-shaped metadata contract into callers when the implementation and tests use a map

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@cursor

cursor Bot commented Apr 15, 2026 •

Copy link
Copy Markdown

PR Summary

Low Risk
Low risk: this is a typespec-only change, but it may affect Dialyzer/static analysis expectations for callers relying on the old struct() metadata type.

Overview
Aligns the Commanded.Commands.ExecutionResult t() typespec with runtime behavior by changing the metadata field type from struct() to map().

Reviewed by Cursor Bugbot for commit ae1cc46. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented Apr 15, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@yordis has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 36 minutes and 23 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 36 minutes and 23 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1bbb4765-7f17-4a84-8f62-ff8dc72c21d2

📥 Commits

Reviewing files that changed from the base of the PR and between c677d4c and ae1cc46.

📒 Files selected for processing (1)
  • lib/commanded/commands/execution_result.ex
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch yordis/fix-execution-result-metadata-type

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@yordis
yordis merged commit 2ebcd07 into main Apr 15, 2026
5 checks passed
@yordis
yordis deleted the yordis/fix-execution-result-metadata-type branch April 15, 2026 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant