Skip to content

fix(oxlint-plugin): accept dynamic segment file names without configuration - #7

Merged
yordis merged 1 commit into
mainfrom
yordis/fix-dynamic-segment-filenames
Oct 16, 2026
Merged

yordis merged 1 commit into
mainfrom
yordis/fix-dynamic-segment-filenames

Conversation

@yordis

@yordis yordis commented Oct 16, 2026 •

Copy link
Copy Markdown
Member
  • Routes like [userId].tsx follow the framework's param naming, so presets should accept them out of the box instead of requiring every consumer to configure an ignore pattern.

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

…ration

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@cursor

cursor Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

PR Summary

Low Risk
Lint preset and documentation only; no runtime or security impact beyond slightly looser filename-case acceptance for bracketed route files.

Overview
The naming.json shareable config now ships a built-in ignore regex on unicorn/filename-case, so Next.js-style dynamic route files such as [userId].tsx and [...filePath].tsx pass kebab-case linting without consumers copying an ignore pattern into their own .oxlintrc.json.

The README caveats were shortened to document that behavior and drop the manual override example. Preset tests were extended to cover those filenames and to assert that names that only look like segments (e.g. UserCard.tsx, [userId]Card.tsx) still fail the rule.

Reviewed by Cursor Bugbot for commit 04aba29. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented Oct 16, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 27 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f7f35462-1641-45b9-b593-0530e77e9bab
📥 Commits

Reviewing files that changed from the base of the PR and between 44e62a2 and 04aba29.

📒 Files selected for processing: 3
  • packages/@trogonstack/oxlint-plugin/README.md
  • packages/@trogonstack/oxlint-plugin/configs/naming.json
  • packages/@trogonstack/oxlint-plugin/tests/node/configs/presets.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@yordis
yordis merged commit a46c89f into main Oct 16, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant