Skip to content

chore: sync with upstream pingdotgg/t3code main - #134

Merged
yordis merged 5 commits into
mainfrom
yordis/chore-sync-upstream-20261021-2
Oct 21, 2026
Merged

yordis merged 5 commits into
mainfrom
yordis/chore-sync-upstream-20261021-2

Conversation

@yordis

@yordis yordis commented Oct 21, 2026 •

Copy link
Copy Markdown
Member
  • Brings in upstream 61e2747..6a6c84f: the Electron 44.9.3 security bump, delegate stop clearing a stuck delegate, thread links rendering as chips, and the React Compiler coverage test timeout fix.
  • Git merged every file cleanly, so no ledger divergence needed re-applying and no entry was retired.
  • The auto-merged lockfile was accepted as is because a frozen install resolves it without changes against the fork's vite-plus 1.1.0 catalog.
  • Local full-suite fallout is host-only: the Linux URL handler icon tests collide on a case-insensitive volume, and the mobile branch checkout tests fail only under this machine's git identity policy hook; both files are byte-identical to upstream and pass under a scratch identity.

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

t3dotgg and others added 5 commits October 20, 2026 22:47
… keys (pingdotgg#22645)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…w CI runners (pingdotgg#22649)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ck (pingdotgg#22653)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…pstream-20261021-2

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@cursor

cursor Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

PR Summary

Medium Risk
Orchestration stop/cancel behavior changes affect delegated task lifecycle and MCP cancel responses; Electron and UI/test changes are lower risk.

Overview
Bumps Electron from 44.4.5 to 44.9.3 (desktop app and lockfile).

Fixes stuck delegated / app-owned tasks (pingdotgg#19002): subagent.stop and MCP cancel now cancel orphaned follow-ups on the parent when the child lost the binding, while tasks with a bound child run keep their normal settlement path. Cancelling a terminal orphan also stops the child thread when a finished run could still start another turn. Shared writeAppOwnedTask centralizes marking tasks, nodes, and turn items cancelled and disposing completion delivery.

Markdown thread links now render through ThreadContextChip (project favicon when known) with chat markdown CSS updated so chips are not styled like plain info links.

React Compiler coverage test gives ChatView.tsx a 60s timeout so CI does not flake on the large file.

Reviewed by Cursor Bugbot for commit 95804d2. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L labels Oct 21, 2026
@github-actions

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 5.0 KiB 5.0 KiB −7 B (−0.1%) 6.8 KiB ✅
Codex Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Codex Live turn WebSocket wire 1.2 KiB 1.2 KiB −7 B (−0.6%) 2.0 KiB ✅
Codex Live turn WebSocket decoded 20.9 KiB 20.9 KiB 0 B (0.0%) 29.3 KiB ✅
Codex Live turn messages 2 2 0 (0.0%) 8 ✅
Claude Total thread wire 5.0 KiB 5.0 KiB +7 B (+0.1%) 6.8 KiB ✅
Claude Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Claude Live turn WebSocket wire 1.2 KiB 1.2 KiB +7 B (+0.6%) 2.0 KiB ✅
Claude Live turn WebSocket decoded 21.2 KiB 21.2 KiB 0 B (0.0%) 29.3 KiB ✅
Claude Live turn messages 2 2 0 (0.0%) 8 ✅

Baseline: 64da884 · PR result: 95804d2 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 108.5 KiB
  • Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@yordis
yordis merged commit 9a4aa01 into main Oct 21, 2026
25 of 28 checks passed
@yordis
yordis deleted the yordis/chore-sync-upstream-20261021-2 branch October 21, 2026 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants