Skip to content

fix(resource-telemetry): find the resource monitor from the built server and clear stale retry errors - #136

Merged
yordis merged 2 commits into
mainfrom
yordis/fix-resource-monitor-discovery
Oct 21, 2026
Merged

yordis merged 2 commits into
mainfrom
yordis/fix-resource-monitor-discovery

Conversation

@yordis

@yordis yordis commented Oct 21, 2026 •

Copy link
Copy Markdown
Member
  • A plain cargo release build of the resource monitor was invisible to the server when it runs from its build output, so desktop dev reported the monitor as missing and exported no process metrics.
  • After a successful Retry monitor, Diagnostics kept showing the old failure even though the monitor was healthy, which made a working recovery look broken.

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

…build output

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
…etry

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@coderabbitai

coderabbitai Bot commented Oct 21, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 50 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Path: .coderabbit.config.ts
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a6ab7d74-14ad-460e-a2f6-a04f41cf1f93
📥 Commits

Reviewing files that changed from the base of the PR and between 9a4aa01 and dddc63a.

📒 Files selected for processing: 4
  • apps/server/src/resourceTelemetry/ResourceMonitorBinary.test.ts
  • apps/server/src/resourceTelemetry/ResourceMonitorBinary.ts
  • apps/web/src/components/settings/ResourceTelemetryDiagnostics.tsx
  • apps/web/src/lib/resourceTelemetryState.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cursor

cursor Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

PR Summary

Low Risk
Localized path-resolution and client-side query refresh after an existing retry flow; no auth or data-model changes.

Overview
Resource monitor binary discovery now builds Cargo output search paths systematically: for each of the monorepo and bundled-server native/resource-monitor roots it checks target/<rust-target>/release, target/release, and target/debug, so a plain cargo build --release is visible when the server runs from its build output. A server test asserts those paths appear on ResourceMonitorBinaryNotFound.

Diagnostics after Retry monitor refresh telemetry (and history in the UI) on a successful retry so cached query errors and stale failure UI clear once the collector is healthy again.

Reviewed by Cursor Bugbot for commit dddc63a. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions github-actions Bot added size:M vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Oct 21, 2026
@github-actions

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 5.0 KiB 5.0 KiB 0 B (0.0%) 6.8 KiB ✅
Codex Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Codex Live turn WebSocket wire 1.2 KiB 1.2 KiB 0 B (0.0%) 2.0 KiB ✅
Codex Live turn WebSocket decoded 20.9 KiB 20.9 KiB 0 B (0.0%) 29.3 KiB ✅
Codex Live turn messages 2 2 0 (0.0%) 8 ✅
Claude Total thread wire 5.0 KiB 5.0 KiB −7 B (−0.1%) 6.8 KiB ✅
Claude Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Claude Live turn WebSocket wire 1.2 KiB 1.2 KiB −7 B (−0.6%) 2.0 KiB ✅
Claude Live turn WebSocket decoded 21.2 KiB 21.2 KiB 0 B (0.0%) 29.3 KiB ✅
Claude Live turn messages 2 2 0 (0.0%) 8 ✅

Baseline: 9a4aa01 · PR result: dddc63a · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 108.5 KiB
  • Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@yordis
yordis merged commit e09c6cc into main Oct 21, 2026
27 of 28 checks passed
@yordis
yordis deleted the yordis/fix-resource-monitor-discovery branch October 21, 2026 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant