Skip to content

fix(web): secret references get the room to be read - #185

Merged
yordis merged 1 commit into
mainfrom
yordis/fix-secret-source-icon-wide-input
Oct 30, 2026
Merged

yordis merged 1 commit into
mainfrom
yordis/fix-secret-source-icon-wide-input

Conversation

@yordis

@yordis yordis commented Oct 30, 2026

Copy link
Copy Markdown
Member
  • The provider picker took most of the row, squeezing the secret reference to a few characters, so the reference could not be read or edited comfortably.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@yordis
yordis merged commit 30398aa into main Oct 30, 2026
4 checks passed
@yordis
yordis deleted the yordis/fix-secret-source-icon-wide-input branch October 30, 2026 17:00
@cursor

cursor Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

PR Summary

Low Risk
UI-only layout and display changes in settings secret inputs; no auth, data, or API behavior changes.

Overview
Fixes cramped secret reference editing in provider/environment settings by shrinking the source picker and letting the reference field use the remaining width.

The secret source Select trigger is now icon-only (SourceIcon) with a title tooltip for the provider name, and uses w-auto shrink-0 instead of a full-width label. Fixed-width wrappers (w-48 / w-28) around the picker in ProviderInstanceCard and the default SecretSourceInput layout are removed so the reference DraftInput can flex-1 and show more of the path.

Reviewed by Cursor Bugbot for commit 1fc98ec. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S labels Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant