Repository navigation
chore(license): clarify ownership boundaries - #278
Merged
Merged
Conversation
PR SummaryLow Risk Overview Experiments are explicitly UNLICENSED and proprietary by default via new Rust CI’s lint job now runs a composite Reviewed by Cursor Bugbot for commit d48da08. Bugbot is set up for automated code reviews on this repo. Configure here. |
WalkthroughThis PR migrates the repository and all Rust crates from MIT to Apache-2.0 licensing. The root LICENSE file is replaced, a CI validation step enforces Apache-2.0 declarations in every crate manifest, the experiments directory is marked proprietary UNLICENSED, and 16 crates are updated to declare Apache-2.0 compliance in their Cargo.toml files. ChangesLicensing Migration and Compliance
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Code Coverage SummaryDetailsDiff against mainResults for commit: d48da08 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ci-rust.yml:
- Around line 61-63: The current check uses packageLines.includes(...) which
compares raw text and can false-positive on formatting/comments; instead parse
the manifest TOML and compare the parsed license value to expectedLicense.
Modify the logic around pkg.license, expectedLicense, packageLines and
violations (and use pkg.manifest_path for context) to join the packageLines into
a string, parse it with a TOML parser (or toml.from_str) to extract the
package.license field, and only push a violation when the parsed license value
does not equal expectedLicense; remove the raw includes(...) text check.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 7a32d476-6666-4bec-996f-49f0d012079f
📒 Files selected for processing (21)
.github/workflows/ci-rust.ymlLICENSEexperiments/LICENSEexperiments/README.mdrsworkspace/crates/acp-nats-agent/Cargo.tomlrsworkspace/crates/acp-nats-server/Cargo.tomlrsworkspace/crates/acp-nats-stdio/Cargo.tomlrsworkspace/crates/acp-nats/Cargo.tomlrsworkspace/crates/mcp-nats-server/Cargo.tomlrsworkspace/crates/mcp-nats-stdio/Cargo.tomlrsworkspace/crates/mcp-nats/Cargo.tomlrsworkspace/crates/trogon-decider-nats/Cargo.tomlrsworkspace/crates/trogon-decider-runtime/Cargo.tomlrsworkspace/crates/trogon-decider/Cargo.tomlrsworkspace/crates/trogon-gateway/Cargo.tomlrsworkspace/crates/trogon-nats/Cargo.tomlrsworkspace/crates/trogon-scheduler/Cargo.tomlrsworkspace/crates/trogon-service-config/Cargo.tomlrsworkspace/crates/trogon-std/Cargo.tomlrsworkspace/crates/trogon-telemetry/Cargo.tomlrsworkspace/crates/trogonai-proto/Cargo.toml
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
yordis
force-pushed
the
yordis/chore-license-rules
branch
from
June 12, 2026 18:49
5ffa477 to
d48da08
Compare
yordis
added
the
rust:coverage-baseline-reset
yordis
added a commit
that referenced
this pull request
Jun 18, 2026
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
experiments/directory is kept UNLICENSED by default so speculative work is clearly separated from the supported open-source surface — anyone looking at the repo can see exactly what is happening and what the boundaries areenforce-cargo-licenseprevents future licensing drift across crates