Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions templates/code/rust/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,17 @@ let tracer = semconv::tracer::Tracer::new(&provider, options);
```

Use `InstrumentationOptions::default()` when no scope attributes are needed.

The constructors accept unsized providers, so a handle can come straight from
the global provider without a wrapper type:

```rust
let meter = semconv::meter::Meter::new(
&*opentelemetry::global::meter_provider(),
semconv::options::InstrumentationOptions::default(),
);
```

The instrumentation identity is fixed during generation. Set
`instrumentation_name` and `instrumentation_version` in the Weaver params to
choose its name and version. The name defaults to `generated-semconv`; an empty
Expand Down
2 changes: 1 addition & 1 deletion templates/code/rust/logger.rs.j2
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ use super::options::InstrumentationOptions;
pub struct Logger<L: opentelemetry::logs::Logger = <opentelemetry::logs::NoopLoggerProvider as opentelemetry::logs::LoggerProvider>::Logger>(L);

impl<L: opentelemetry::logs::Logger> Logger<L> {
pub fn new<P: opentelemetry::logs::LoggerProvider<Logger = L>>(provider: &P, options: InstrumentationOptions) -> Self {
pub fn new<P: opentelemetry::logs::LoggerProvider<Logger = L> + ?Sized>(provider: &P, options: InstrumentationOptions) -> Self {
let logger = provider.logger_with_scope(options.scope.into());
Self(logger)
}
Expand Down
2 changes: 1 addition & 1 deletion templates/code/rust/meter.rs.j2
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ use super::options::InstrumentationOptions;
pub struct Meter(opentelemetry::metrics::Meter);

impl Meter {
pub fn new(provider: &impl opentelemetry::metrics::MeterProvider, options: InstrumentationOptions) -> Self {
pub fn new(provider: &(impl opentelemetry::metrics::MeterProvider + ?Sized), options: InstrumentationOptions) -> Self {
let meter = provider.meter_with_scope(options.scope.into());
Self(meter)
}
Expand Down
2 changes: 1 addition & 1 deletion templates/code/rust/tests/allocations/expected/logger.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use super::options::InstrumentationOptions;
pub struct Logger<L: opentelemetry::logs::Logger = <opentelemetry::logs::NoopLoggerProvider as opentelemetry::logs::LoggerProvider>::Logger>(L);

impl<L: opentelemetry::logs::Logger> Logger<L> {
pub fn new<P: opentelemetry::logs::LoggerProvider<Logger = L>>(provider: &P, options: InstrumentationOptions) -> Self {
pub fn new<P: opentelemetry::logs::LoggerProvider<Logger = L> + ?Sized>(provider: &P, options: InstrumentationOptions) -> Self {
let logger = provider.logger_with_scope(options.scope.into());
Self(logger)
}
Expand Down
2 changes: 1 addition & 1 deletion templates/code/rust/tests/allocations/expected/meter.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use super::options::InstrumentationOptions;
pub struct Meter(opentelemetry::metrics::Meter);

impl Meter {
pub fn new(provider: &impl opentelemetry::metrics::MeterProvider, options: InstrumentationOptions) -> Self {
pub fn new(provider: &(impl opentelemetry::metrics::MeterProvider + ?Sized), options: InstrumentationOptions) -> Self {
let meter = provider.meter_with_scope(options.scope.into());
Self(meter)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use super::options::InstrumentationOptions;
pub struct Logger<L: opentelemetry::logs::Logger = <opentelemetry::logs::NoopLoggerProvider as opentelemetry::logs::LoggerProvider>::Logger>(L);

impl<L: opentelemetry::logs::Logger> Logger<L> {
pub fn new<P: opentelemetry::logs::LoggerProvider<Logger = L>>(provider: &P, options: InstrumentationOptions) -> Self {
pub fn new<P: opentelemetry::logs::LoggerProvider<Logger = L> + ?Sized>(provider: &P, options: InstrumentationOptions) -> Self {
let logger = provider.logger_with_scope(options.scope.into());
Self(logger)
}
Expand Down
2 changes: 1 addition & 1 deletion templates/code/rust/tests/events/expected/logger.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use super::options::InstrumentationOptions;
pub struct Logger<L: opentelemetry::logs::Logger = <opentelemetry::logs::NoopLoggerProvider as opentelemetry::logs::LoggerProvider>::Logger>(L);

impl<L: opentelemetry::logs::Logger> Logger<L> {
pub fn new<P: opentelemetry::logs::LoggerProvider<Logger = L>>(provider: &P, options: InstrumentationOptions) -> Self {
pub fn new<P: opentelemetry::logs::LoggerProvider<Logger = L> + ?Sized>(provider: &P, options: InstrumentationOptions) -> Self {
let logger = provider.logger_with_scope(options.scope.into());
Self(logger)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use super::options::InstrumentationOptions;
pub struct Meter(opentelemetry::metrics::Meter);

impl Meter {
pub fn new(provider: &impl opentelemetry::metrics::MeterProvider, options: InstrumentationOptions) -> Self {
pub fn new(provider: &(impl opentelemetry::metrics::MeterProvider + ?Sized), options: InstrumentationOptions) -> Self {
let meter = provider.meter_with_scope(options.scope.into());
Self(meter)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use super::options::InstrumentationOptions;
pub struct Meter(opentelemetry::metrics::Meter);

impl Meter {
pub fn new(provider: &impl opentelemetry::metrics::MeterProvider, options: InstrumentationOptions) -> Self {
pub fn new(provider: &(impl opentelemetry::metrics::MeterProvider + ?Sized), options: InstrumentationOptions) -> Self {
let meter = provider.meter_with_scope(options.scope.into());
Self(meter)
}
Expand Down
2 changes: 1 addition & 1 deletion templates/code/rust/tests/imported/expected/logger.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use super::options::InstrumentationOptions;
pub struct Logger<L: opentelemetry::logs::Logger = <opentelemetry::logs::NoopLoggerProvider as opentelemetry::logs::LoggerProvider>::Logger>(L);

impl<L: opentelemetry::logs::Logger> Logger<L> {
pub fn new<P: opentelemetry::logs::LoggerProvider<Logger = L>>(provider: &P, options: InstrumentationOptions) -> Self {
pub fn new<P: opentelemetry::logs::LoggerProvider<Logger = L> + ?Sized>(provider: &P, options: InstrumentationOptions) -> Self {
let logger = provider.logger_with_scope(options.scope.into());
Self(logger)
}
Expand Down
2 changes: 1 addition & 1 deletion templates/code/rust/tests/imported/expected/meter.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use super::options::InstrumentationOptions;
pub struct Meter(opentelemetry::metrics::Meter);

impl Meter {
pub fn new(provider: &impl opentelemetry::metrics::MeterProvider, options: InstrumentationOptions) -> Self {
pub fn new(provider: &(impl opentelemetry::metrics::MeterProvider + ?Sized), options: InstrumentationOptions) -> Self {
let meter = provider.meter_with_scope(options.scope.into());
Self(meter)
}
Expand Down
2 changes: 1 addition & 1 deletion templates/code/rust/tests/imported/expected/tracer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use super::options::InstrumentationOptions;
pub struct Tracer<T: opentelemetry::trace::Tracer = opentelemetry::trace::noop::NoopTracer>(T);

impl<T: opentelemetry::trace::Tracer> Tracer<T> {
pub fn new<P: opentelemetry::trace::TracerProvider<Tracer = T>>(provider: &P, options: InstrumentationOptions) -> Self {
pub fn new<P: opentelemetry::trace::TracerProvider<Tracer = T> + ?Sized>(provider: &P, options: InstrumentationOptions) -> Self {
let tracer = provider.tracer_with_scope(options.scope.into());
Self(tracer)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use super::options::InstrumentationOptions;
pub struct Logger<L: opentelemetry::logs::Logger = <opentelemetry::logs::NoopLoggerProvider as opentelemetry::logs::LoggerProvider>::Logger>(L);

impl<L: opentelemetry::logs::Logger> Logger<L> {
pub fn new<P: opentelemetry::logs::LoggerProvider<Logger = L>>(provider: &P, options: InstrumentationOptions) -> Self {
pub fn new<P: opentelemetry::logs::LoggerProvider<Logger = L> + ?Sized>(provider: &P, options: InstrumentationOptions) -> Self {
let logger = provider.logger_with_scope(options.scope.into());
Self(logger)
}
Expand Down
2 changes: 1 addition & 1 deletion templates/code/rust/tests/imported_typed/expected/meter.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use super::options::InstrumentationOptions;
pub struct Meter(opentelemetry::metrics::Meter);

impl Meter {
pub fn new(provider: &impl opentelemetry::metrics::MeterProvider, options: InstrumentationOptions) -> Self {
pub fn new(provider: &(impl opentelemetry::metrics::MeterProvider + ?Sized), options: InstrumentationOptions) -> Self {
let meter = provider.meter_with_scope(options.scope.into());
Self(meter)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use super::options::InstrumentationOptions;
pub struct Tracer<T: opentelemetry::trace::Tracer = opentelemetry::trace::noop::NoopTracer>(T);

impl<T: opentelemetry::trace::Tracer> Tracer<T> {
pub fn new<P: opentelemetry::trace::TracerProvider<Tracer = T>>(provider: &P, options: InstrumentationOptions) -> Self {
pub fn new<P: opentelemetry::trace::TracerProvider<Tracer = T> + ?Sized>(provider: &P, options: InstrumentationOptions) -> Self {
let tracer = provider.tracer_with_scope(options.scope.into());
Self(tracer)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use super::options::InstrumentationOptions;
pub struct Meter(opentelemetry::metrics::Meter);

impl Meter {
pub fn new(provider: &impl opentelemetry::metrics::MeterProvider, options: InstrumentationOptions) -> Self {
pub fn new(provider: &(impl opentelemetry::metrics::MeterProvider + ?Sized), options: InstrumentationOptions) -> Self {
let meter = provider.meter_with_scope(options.scope.into());
Self(meter)
}
Expand Down
2 changes: 1 addition & 1 deletion templates/code/rust/tests/metrics/expected/meter.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use super::options::InstrumentationOptions;
pub struct Meter(opentelemetry::metrics::Meter);

impl Meter {
pub fn new(provider: &impl opentelemetry::metrics::MeterProvider, options: InstrumentationOptions) -> Self {
pub fn new(provider: &(impl opentelemetry::metrics::MeterProvider + ?Sized), options: InstrumentationOptions) -> Self {
let meter = provider.meter_with_scope(options.scope.into());
Self(meter)
}
Expand Down
29 changes: 29 additions & 0 deletions templates/code/rust/tests/metrics/test.rs
Original file line number Diff line number Diff line change
Expand Up @@ -365,3 +365,32 @@ fn instruments_expose_registry_metadata_as_constants() {
metric::AuthAttempts::DESCRIPTION
);
}

#[test]
fn meter_accepts_the_global_provider_trait_object() {
let (provider, exporter) = provider();
opentelemetry::global::set_meter_provider(provider.clone());
let meter = meter::Meter::new(
&*opentelemetry::global::meter_provider(),
InstrumentationOptions::default(),
);
metric::MyappTaskStarted::new(&meter).add(
1,
[metric::MyappTaskStartedAttr::TaskId(
attribute::MyappTaskId::from("global"),
)],
);

provider.force_flush().unwrap();
let exported = exporter.get_finished_metrics().unwrap();
let scope = exported[0].scope_metrics().next().unwrap();
assert_eq!(scope.scope().name(), "generated-semconv");
assert_eq!(
scope.scope().schema_url(),
Some(generated_semconv::SCHEMA_URL)
);
assert_eq!(
scope.metrics().next().unwrap().name(),
metric::MyappTaskStarted::NAME
);
}
2 changes: 1 addition & 1 deletion templates/code/rust/tests/naming/expected/meter.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use super::options::InstrumentationOptions;
pub struct Meter(opentelemetry::metrics::Meter);

impl Meter {
pub fn new(provider: &impl opentelemetry::metrics::MeterProvider, options: InstrumentationOptions) -> Self {
pub fn new(provider: &(impl opentelemetry::metrics::MeterProvider + ?Sized), options: InstrumentationOptions) -> Self {
let meter = provider.meter_with_scope(options.scope.into());
Self(meter)
}
Expand Down
2 changes: 1 addition & 1 deletion templates/code/rust/tests/no_namespace/expected/logger.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use super::options::InstrumentationOptions;
pub struct Logger<L: opentelemetry::logs::Logger = <opentelemetry::logs::NoopLoggerProvider as opentelemetry::logs::LoggerProvider>::Logger>(L);

impl<L: opentelemetry::logs::Logger> Logger<L> {
pub fn new<P: opentelemetry::logs::LoggerProvider<Logger = L>>(provider: &P, options: InstrumentationOptions) -> Self {
pub fn new<P: opentelemetry::logs::LoggerProvider<Logger = L> + ?Sized>(provider: &P, options: InstrumentationOptions) -> Self {
let logger = provider.logger_with_scope(options.scope.into());
Self(logger)
}
Expand Down
2 changes: 1 addition & 1 deletion templates/code/rust/tests/no_namespace/expected/tracer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use super::options::InstrumentationOptions;
pub struct Tracer<T: opentelemetry::trace::Tracer = opentelemetry::trace::noop::NoopTracer>(T);

impl<T: opentelemetry::trace::Tracer> Tracer<T> {
pub fn new<P: opentelemetry::trace::TracerProvider<Tracer = T>>(provider: &P, options: InstrumentationOptions) -> Self {
pub fn new<P: opentelemetry::trace::TracerProvider<Tracer = T> + ?Sized>(provider: &P, options: InstrumentationOptions) -> Self {
let tracer = provider.tracer_with_scope(options.scope.into());
Self(tracer)
}
Expand Down
2 changes: 1 addition & 1 deletion templates/code/rust/tests/params/expected/logger.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use super::options::InstrumentationOptions;
pub struct Logger<L: opentelemetry::logs::Logger = <opentelemetry::logs::NoopLoggerProvider as opentelemetry::logs::LoggerProvider>::Logger>(L);

impl<L: opentelemetry::logs::Logger> Logger<L> {
pub fn new<P: opentelemetry::logs::LoggerProvider<Logger = L>>(provider: &P, options: InstrumentationOptions) -> Self {
pub fn new<P: opentelemetry::logs::LoggerProvider<Logger = L> + ?Sized>(provider: &P, options: InstrumentationOptions) -> Self {
let logger = provider.logger_with_scope(options.scope.into());
Self(logger)
}
Expand Down
2 changes: 1 addition & 1 deletion templates/code/rust/tests/params/expected/meter.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use super::options::InstrumentationOptions;
pub struct Meter(opentelemetry::metrics::Meter);

impl Meter {
pub fn new(provider: &impl opentelemetry::metrics::MeterProvider, options: InstrumentationOptions) -> Self {
pub fn new(provider: &(impl opentelemetry::metrics::MeterProvider + ?Sized), options: InstrumentationOptions) -> Self {
let meter = provider.meter_with_scope(options.scope.into());
Self(meter)
}
Expand Down
2 changes: 1 addition & 1 deletion templates/code/rust/tests/params/expected/tracer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use super::options::InstrumentationOptions;
pub struct Tracer<T: opentelemetry::trace::Tracer = opentelemetry::trace::noop::NoopTracer>(T);

impl<T: opentelemetry::trace::Tracer> Tracer<T> {
pub fn new<P: opentelemetry::trace::TracerProvider<Tracer = T>>(provider: &P, options: InstrumentationOptions) -> Self {
pub fn new<P: opentelemetry::trace::TracerProvider<Tracer = T> + ?Sized>(provider: &P, options: InstrumentationOptions) -> Self {
let tracer = provider.tracer_with_scope(options.scope.into());
Self(tracer)
}
Expand Down
2 changes: 1 addition & 1 deletion templates/code/rust/tests/spans/expected/tracer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use super::options::InstrumentationOptions;
pub struct Tracer<T: opentelemetry::trace::Tracer = opentelemetry::trace::noop::NoopTracer>(T);

impl<T: opentelemetry::trace::Tracer> Tracer<T> {
pub fn new<P: opentelemetry::trace::TracerProvider<Tracer = T>>(provider: &P, options: InstrumentationOptions) -> Self {
pub fn new<P: opentelemetry::trace::TracerProvider<Tracer = T> + ?Sized>(provider: &P, options: InstrumentationOptions) -> Self {
let tracer = provider.tracer_with_scope(options.scope.into());
Self(tracer)
}
Expand Down
2 changes: 1 addition & 1 deletion templates/code/rust/tracer.rs.j2
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ use super::options::InstrumentationOptions;
pub struct Tracer<T: opentelemetry::trace::Tracer = opentelemetry::trace::noop::NoopTracer>(T);

impl<T: opentelemetry::trace::Tracer> Tracer<T> {
pub fn new<P: opentelemetry::trace::TracerProvider<Tracer = T>>(provider: &P, options: InstrumentationOptions) -> Self {
pub fn new<P: opentelemetry::trace::TracerProvider<Tracer = T> + ?Sized>(provider: &P, options: InstrumentationOptions) -> Self {
let tracer = provider.tracer_with_scope(options.scope.into());
Self(tracer)
}
Expand Down
Loading