Repository navigation
fix(wal): read the log and replay refs through the caller's manifest - #12
Conversation
yordis
commented
Oct 23, 2026
- The events bridge silently skipped a committed entry when another instance's checkpoint folded it.
- Brings in fix(wal): read the log and replay refs through the caller's manifest tobi/walgit#107 by cyharyanto, cherry-picked with original authorship; the upstream test fails on our main and passes with this change.
PR SummaryMedium Risk Overview This fixes the events bridge skipping a committed seq when catch-up uses a manifest with Adds an integration test for checkpoint during bridge catch-up (sibling folds seq 2 while the bridge holds an older manifest view with Reviewed by Cursor Bugbot for commit 3b1ef63. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 14
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
catch_up took head_seq from one manifest while read_log resolved a fresher one; a checkpoint in between trims that one's segments, so the bridge emitted nothing and advanced its cursor past the push. read_log, refs_at_seq, refs_as_of and the checkpoint-time helpers now take the caller's manifest, and fresh_manifest() is the explicit way to get the newest one. Round trips: the bridge catch-up, the settings history and policy dry-run, the repository overview and `walgit settings history` each made two conditional manifest GETs (the sync, then read_log's own) and now make one; `walgit wal ls` and `wal show` still make one. No budget in docs/ROUNDTRIPS.md changes. (cherry picked from commit 7844344) Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
3b1ef63 to
600e10b
Compare
fdc6d25 to
5afc103
Compare