[yordis]

• LFS handlers had no outcome metrics, so failures and rejected uploads were invisible to operators.
• Byte counters must distinguish what a client offered from what was validated and stored, or dashboards overstate real traffic.
• Brings in feat(lfs): record handler outcomes and honest byte metrics tobi/walgit#62 by Tobi Lütke, cherry-picked with original authorship.

[cursor]

PR Summary

Low Risk
Observability-only refactor with no auth or storage logic changes; minor overhead from metric recording on the LFS hot path.

Overview
Adds Prometheus-style metrics around the LFS batch, get, put, and verify handlers without changing transfer behavior. Each public handler now wraps the existing logic in an *_inner function, records walgit_lfs_handler_seconds{op} and walgit_lfs_requests_total{op,result} (mapping HTTP and ApiError outcomes to ok, not_found, or error), and returns the same response as before.

GET responses additionally feed walgit_lfs_response_bytes_offered_total from Content-Length on successful GET/206 only—explicitly skipping HEAD, errors, 304, and x-accel-redirect edge offload so dashboards reflect offered body size, not completed downloads. PUT increments walgit_lfs_upload_bytes_validated_total and walgit_lfs_upload_object_bytes after the upload body is fully read and SHA-256 checks pass, even if the subsequent store write fails.

docs/LFS.md documents what these series mean (handler completion vs streaming, batch per-object errors in 200 responses). A unit test locks in the download-offer filters and error outcome labeling.

^{Reviewed by Cursor Bugbot for commit 1c9c775. Bugbot is set up for automated code reviews on this repo. Configure here.}

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: b690c1c2-1e8c-4d94-988b-9b2ac09dd85f

Commits

Reviewing files that changed from the base of the PR and between 7ea667a and 1c9c775.

Files selected for processing: 2

• crates/walgit-server/src/lfs.rs
• docs/LFS.md

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn