feat: member-reachable check-only sandbox - #128
Merged
Merged
Conversation
The Test a Fit page (including its persist-nothing check-only mode) was gated to doctrine managers and reviewers, so members had no way to grade a fit they don't own yet. Since the sandbox creates no submission, findings, log rows, or reviewer notifications, that gate is now needed only for the persisting save path: any member who can see the fitting may GET the page and POST check-only; a save-mode POST without staff permissions is still denied. The FAQ pilot answer and README are updated to match. Closes #117.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #117.
The Test a Fit page — including its check-only sandbox mode — was gated to
manage_doctrines/reviewer permissions, so a plain member could only ever be graded on ships they already own via ESI. The sandbox persists nothing (no FitSubmission/findings/log rows, no reviewer notification), so that restriction is only needed for the persisting save path.Changes
submit_eft: any member who can see the fit (category visibility unchanged) may GET the page and POSTmode=check_only; a persisting POST without staff permissions raises 403 (defense in depth on top of the hidden button). Staff behavior unchanged.fit_detailnow offers the Test a Fit button to every authorized viewer.submit_eft.html: the save button renders only for staff (can_submit_paste); for members the check-only button becomes primary with a note that results are informational and real submissions come from My Ships. The mutated-stats detour already carries the check-only flag.Tested: 6 new tests (member GET shows check-only-only form; staff keeps save; member check-only grades and persists nothing + no notification; member save-POST 403; mutated detour carries check-only and persists nothing; fit-detail link for members) + updated gating test. Full suite 715 green;
check+makemigrations --checkclean. No migration, no new static files.