Pilot history: filter bar and removable rejected rows - #132
Merged
Merged
Conversation
Adds a filter bar (status, verdict, doctrine, character, ship) to the pilot's own validation history, mirroring the reviewer queue's filter mechanics. Doctrine and character options are scoped to the pilot's own submissions only, so a filter never leaks the name of a doctrine the pilot can't otherwise see. Pilots can now remove a rejected submission from their own history: it's hidden from that view only (FitSubmission.hidden_at), not deleted, so reviewers and reports still see it. Pending submissions in the same "Remove selected" action are still deleted outright, unchanged from before. Approved submissions remain untouched either way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FitSubmission.hidden_at, migration 0038) rather than deleted, so reviewers and reports still see it and the decision stays on the audit trail. Pending submissions are still hard-deleted by the same "Remove selected" action / single-delete endpoint, unchanged. Approved submissions are untouched either way.Why
The pilot's history page had no way to filter a growing list of past submissions, and rejected submissions cluttered it permanently with no way for the pilot to clean them up - reviewers still need those rows for the audit trail, so a hard delete wasn't appropriate.
Test plan
manage.py test fitcheck- full suite green (736 tests)manage.py check- cleanmanage.py makemigrations fitcheck --check --dry-run- no missing migrations